Repository navigation
Conversation
On Rails 8.1, requiring rails/railtie on its own raises NoMethodError (delegate_missing_to is undefined), which broke the test suite. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Active Support < 8.1 passes the quirks_mode option that json 3 removed, so these gemfiles keep json 2. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
pull_request_target checks out main, so pull requests ran main's code instead of their own. Pin ubuntu-24.04, which still has Ruby 3.2 builds, and let setup-ruby cache the bundle. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Both reached end of life. Without Ruby 3.2 the workflow can run on ubuntu-latest again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The offenses this reveals are autocorrected: regexp literals are frozen since Ruby 3.0, Set is autoloaded since 3.2, and blocks can be forwarded anonymously since 3.1. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Author
|
Same as on #564: the red checks above come from the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Nando! Following @mjankowski's suggestion on #564, this drops Ruby 3.2 and Rails 7.2, which both reached end of life. It's stacked on #564, so only the last two commits are new here, and I kept it separate since raising
required_ruby_versionis your call for the next release.gemfiles/7_2.gemfilefrom the matrix.ubuntu-latest, sinceruby/setup-rubyhas Ruby 3.3 builds for Ubuntu 26.04.TargetRubyVersionmoves from 2.5 to 3.3. The 8 offenses this reveals are autocorrected and unchanged in behavior:.freezeon regexp literals (frozen since Ruby 3.0),require "set"(autoloaded since 3.2) and anonymous block forwarding.bundle exec rakepasses locally with Ruby 4.0 on both remaining gemfiles. Rails 8.0 reaches end of life soon too; I left it in the matrix for now, as it's the only thing still needingjson < 3. Happy to drop it here as well if you prefer!🤖 Generated with Claude Code, but prompted, read, and verified by @czj, a caring human :)