Repository navigation
Conversation
On Rails 8.1, requiring rails/railtie on its own raises NoMethodError (delegate_missing_to is undefined), which broke the test suite. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Active Support < 8.1 passes the quirks_mode option that json 3 removed, so these gemfiles keep json 2. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
pull_request_target checks out main, so pull requests ran main's code instead of their own. Pin ubuntu-24.04, which still has Ruby 3.2 builds, and let setup-ruby cache the bundle. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The red checks above come from the |
|
I had forgotten about that old PR. If this does get a review, you way to contemplate dropping support for ruby 3.2 and rails 7.2 as well (next time you bump gem version), both of which are EOL (and rails 8.0 will be EOL in a few weeks). Might simplify some of the conditional setup/versioning in here. |
|
Thanks @mjankowski, good point! I'd rather keep this one about getting CI green, since dropping Ruby 3.2 and Rails 7.2 raises the gem's requirements and is really Nando's call for the next release. So I opened #565 on top of this branch: it requires Ruby 3.3, removes the 7.2 gemfile, lets the workflow go back to |
Hi Nando! While opening #563, I noticed that every CI job is red, and that none of them actually tests the pull request.
The workflow runs on
pull_request_target, whereactions/checkoutchecks outmain, so each PR gets the results ofmain's code. Andmainitself fails for two unrelated reasons. On Rails 8.1,require "rails/railtie"raisesNoMethodError: undefined method 'delegate_missing_to'when nothing loaded Rails before it, which is what the test suite does. On Rails 7.0 and 7.1, Active Support passes thequirks_modeoption that json 3 removed, so one test fails (Rails 8.0 has the same issue).This PR fixes both and brings the matrix up to date, one commit each:
lib/browser/rails.rbrequiresrailsinstead ofrails/railtie. Apps already have Rails loaded at that point, so nothing changes for them.json < 3and a comment saying why. Update CI matrix to include all non-EOL ruby/rails pairings #554 by @mjankowski already proposed adding these two, so credit to them.pull_request, tests Ruby 3.2 (the gemspec's minimum), 3.3, 3.4 and 4.0 against the three gemfiles, and letsruby/setup-rubycache the bundle. It pinsubuntu-24.04, becauseubuntu-latestis moving to 26.04, which has no Ruby 3.2 builds. The Rakefile's--auto-correctbecomes--autocorrect, which RuboCop deprecated.rakealso runs RuboCop, the 6 offenses reported by RuboCop 1.92 are fixed, autocorrected and unchanged in behavior.bundle exec rakepasses locally with Ruby 4.0 on all three gemfiles. This PR's ownpull_request_targetrun will still check outmainand stay red, but the newpull_requestrun tests this branch (it may need your approval since I'm a first-time contributor).🤖 Generated with Claude Code, but prompted, read, and verified by @czj, a caring human :)