Skip to content

feat(ship): add review gate before merge #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chaliy merged 1 commit into from
Mar 27, 2026
+13 −3
Merged

feat(ship): add review gate before merge #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions .agents/skills/ship/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
Run the full ship flow: verify quality, ensure test coverage, update
artifacts, smoke test, then push, create PR, and merge when CI is green.
artifacts, smoke test, then push, create PR, address review comments,
and merge only when CI is green, all threads resolved, and user confirms.

## Phases

Expand Down Expand Up @@ -41,11 +42,20 @@ artifacts, smoke test, then push, create PR, and merge when CI is green.
- `cargo clippy --workspace -- -D warnings`
- `cargo deny check`

### 8. Push, PR, Merge
### 8. Push & PR
- Push branch to remote
- Create or update PR with summary
- Wait for CI to pass
- Merge when green

### 9. Review & Merge
- Check for unresolved review comments — address or reply to each
- Ensure all review threads are resolved
- Confirm no changes-requested reviews remain outstanding
- Ask the user whether to merge now or wait for reviewer feedback
- Only merge when: CI green, no unresolved threads, no pending change requests

**IMPORTANT**: Phases 2-5 (tests, artifacts, simplification, security review,
smoke testing) are the quality core — do NOT skip them.

**IMPORTANT**: Never auto-merge without confirming with the user. PRs should
have time for human review before merging.
Loading