Skip to content

feat(ship): add review gate before merge - #6

Merged
chaliy merged 1 commit into
mainfrom
claude/check-ship-skill-pr-A8inw
Mar 27, 2026
Merged

chaliy merged 1 commit into
mainfrom
claude/check-ship-skill-pr-A8inw

Conversation

@chaliy

@chaliy chaliy commented Mar 27, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Split ship skill Phase 8 ("Push, PR, Merge") into two phases: Push & PR (8) and Review & Merge (9)
  • Phase 9 requires all review threads resolved, no pending change requests, and explicit user confirmation before merging
  • Added guard: "Never auto-merge without confirming with the user"

Test plan

  • Verify SKILL.md renders correctly on GitHub
  • Run /ship on a future PR to confirm the new review gate is followed

Split Phase 8 into Push & PR (8) and Review & Merge (9). The ship
skill now requires all review threads resolved, no pending change
requests, and explicit user confirmation before merging.
@chaliy
chaliy merged commit 6809288 into main Mar 27, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant