Skip to content

🛡️ Sentinel: [CRITICAL] Fix command argument injection - #21

Closed
google-labs-jules[bot] wants to merge 2 commits into
mainfrom
sentinel/fix-command-injection-4317620969320902637
Closed

🛡️ Sentinel: [CRITICAL] Fix command argument injection#21
google-labs-jules[bot] wants to merge 2 commits into
mainfrom
sentinel/fix-command-injection-4317620969320902637

Conversation

@google-labs-jules

Copy link
Copy Markdown

🚨 Severity: CRITICAL
💡 Vulnerability: Command argument injection when passing user-controlled paths to std::process::Command (e.g., for git clone). If a repository path starts with a hyphen (e.g., -u or --upload-pack=...), git might interpret it as a flag.
🎯 Impact: Arbitrary command execution or unexpected behavior.
🔧 Fix: Added -- before the source and destination paths in git clone commands to signal the end of options.
✅ Verification: Ran cargo check and cargo test to verify the fix does not introduce regressions.

Also recorded learning in .jules/sentinel.md.


PR created automatically by Jules for task 4317620969320902637 started by @euxaristia

Added `--` separator before passing user-controlled paths to `git clone` to prevent command argument injection.
Deleted temporary scripts.
@google-labs-jules

Copy link
Copy Markdown
Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions

Copy link
Copy Markdown

Thanks for the contribution. A couple of things will help us review this faster:

  • Link the issue this addresses (Closes #123). For protocol changes, open an issue first.
  • This changes Rust source but no tests changed. Tests are required for fixes and strongly encouraged for features.

See CONTRIBUTING.md. Update the PR and these notes will clear automatically.

…crate

Added `--` separator before passing user-controlled paths to `git clone` to prevent command argument injection. Also updated `h2` to `0.4.16` to fix cargo audit issues (RUSTSEC-2026-0258).
Deleted temporary scripts.
@euxaristia euxaristia closed this Aug 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant