CI を統合して参照設定を更新#3
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 55dcb3d9f4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - name: Setup .NET 9 | ||
| uses: actions/setup-dotnet@v5 | ||
| with: | ||
| dotnet-version: 9.0.x | ||
|
|
||
| - name: Setup Resonite environment | ||
| uses: resonite-modding-group/setup-resonite-env-action@v0.1.0 |
There was a problem hiding this comment.
After deleting static-check.yml, the new CI flow goes directly into environment setup/build and no longer runs dotnet csharpier check ., which removes the formatting gate that this repository documents as required (see root AGENTS.md: “Formatting is enforced with csharpier” and CI static checks). This regression allows formatting violations to merge undetected.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8e54a4b682
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ) | ||
| { | ||
| opusStream = stream as OpusStream<StereoSample>; | ||
| return opusStream?.User?.IsLocalUser != true; |
There was a problem hiding this comment.
IsRemoteReceiverOpusStream returns true even when the cast fails, because opusStream?.User?.IsLocalUser != true evaluates to true for null. With EnableReceiverHeadroomPatch enabled, a non-Opus AudioStream<StereoSample> can therefore pass this guard with opusStream == null, and AudioStreamStereoSample_Read_ReceiverHeadroom_Patch later dereferences opusStream! in its logging path, causing a runtime null-reference in audio playback. Make this predicate explicitly require a non-null cast result before returning true.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1654ad9a6f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1 participant
概要
ci.ymlに CI/release workflow を統合ローカル検証
dotnet restore .\TurboAudioStream.sln -p:ResonitePath="C:\Program Files (x86)\Steam\steamapps\common\Resonite\"dotnet build .\TurboAudioStream.sln -c Release --no-restore -p:ResonitePath="C:\Program Files (x86)\Steam\steamapps\common\Resonite\"dotnet test .\TurboAudioStream.sln -c Release --no-build -p:ResonitePath="C:\Program Files (x86)\Steam\steamapps\common\Resonite\"solution に test project は含まれていないため、
dotnet testは実行対象なしで終了します。