Toggleable E2E audio stability patches#4
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 429745d1ad
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return true; | ||
| } | ||
| catch | ||
| catch (ArgumentException) |
There was a problem hiding this comment.
Catch all stream-id decode failures in drop-log helper
TryReadAsyncStreamId used to absorb any parse error and return false, but this change only handles three exception types. If reader.Read7BitEncoded() or message.GetData() throws another decode-related exception (for example FormatException/OverflowException on malformed varint data), the exception now escapes into Harmony prefixes like SyncController_AsyncStreamDecodeAndDispose_DropLog_Patch, turning a diagnostic logging path into a potential runtime failure in stream processing instead of a no-op log miss.
Useful? React with 👍 / 👎.
Summary
Verification
Notes