Skip to content

Toggleable E2E audio stability patches#4

Open
esnya wants to merge 4 commits into
codex/modernize-ci-and-net10from
codex/e2e-audio-patches
Open

Toggleable E2E audio stability patches#4
esnya wants to merge 4 commits into
codex/modernize-ci-and-net10from
codex/e2e-audio-patches

Conversation

@esnya
Copy link
Copy Markdown
Owner

@esnya esnya commented Apr 21, 2026

Summary

  • add a patch manager that enables and disables Harmony patches per feature
  • add trigger logging for actual patch interventions with cooldown-based deduplication
  • implement outgoing tuning, bind repair, async freshness guard, stream drop logging, and receiver headroom patches

Verification

  • dotnet build TurboAudioStream\TurboAudioStream.csproj
  • csharpier check .

Notes

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 429745d1ad

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread TurboAudioStream/StreamDropLogHelper.cs Outdated
return true;
}
catch
catch (ArgumentException)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Catch all stream-id decode failures in drop-log helper

TryReadAsyncStreamId used to absorb any parse error and return false, but this change only handles three exception types. If reader.Read7BitEncoded() or message.GetData() throws another decode-related exception (for example FormatException/OverflowException on malformed varint data), the exception now escapes into Harmony prefixes like SyncController_AsyncStreamDecodeAndDispose_DropLog_Patch, turning a diagnostic logging path into a potential runtime failure in stream processing instead of a no-op log miss.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant