Repository navigation
Allow newlines in the message composer and fix loading earlier messages - #101
Merged
kody-bot merged 1 commit intoOct 5, 2026
Merged
Conversation
Enter now inserts a newline in the new-message composer (so the mobile Return key no longer queues the message); Cmd/Ctrl+Enter or the button adds it to the queue. Loading earlier messages targeted the parent $recipientId layout loader because the fetcher URL lacked ?index, so pages never got appended. Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
kody-bot
marked this pull request as ready for review
October 5, 2026 20:59
Member
Author
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit cae650e. Configure here.
Merged
1 of 2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the two bugs from this Cap recording on the recipient thread page.
Newlines in the composer. Enter used to add the message to the queue, so on phones the Return key queued half-written notes and there was no obvious way to add a line break. Enter now inserts a newline on every device. Cmd/Ctrl+Enter or the "Add to Queue" button adds the message. The textarea also sets
enterKeyHint="enter"so mobile keyboards label the key as a line break.Infinite scroll. "Scroll up to load earlier messages" never loaded anything. The fetcher loaded
?cursor=…from an index route without?index, so React Router sent the request to the parent$recipientIdlayout loader. That loader has nopastMessagesand nosearchQuery, so the merge effect returned early every time. The fetch now includesindex, and earlier pages append while keeping the scroll position.Test Plan
tests/e2e/recipient-thread.test.ts:First line\nSecond line, and Cmd/Ctrl+Enter queues a second message.main(Enter queues the message, and the thread stays at 30 messages) and pass with this change. They passed 5 repeats each.bun run lint,bun run typecheck, andbun run testpass.Checklist
Screenshots
Before (from the recording): the thread is stuck at "Scroll up to load earlier messages."