Repository navigation
Make Cursor Cloud agents boot ready to work, and stop lint autofix from breaking e2e DB checks - #105
Merged
Merged
Conversation
Builds of the dashboard environment failed every time with 'bun: command not found' because Bun and Node 24 were only on PATH via ~/.bashrc. The committed install script installs both, exposes them on the login-shell PATH, and sets up deps, the database, and Playwright. AGENTS.md now points at it instead of a hard-coded Node patch path and is Prettier-clean. Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
playwright/prefer-to-have-count treats any .count() call as a Locator. Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
kody-bot
marked this pull request as ready for review
October 5, 2026 21:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the agent papercuts filed while shipping #101.
Closes #102
Closes #103
Closes #104
Cloud Agent environment (#102). Every recurring build of the dashboard environment failed with
bash: line 1: bun: command not found(exit 127). Bun and Node 24 were only on PATH through~/.bashrc, which non-interactive login shells never load. Agents fell back to a bare image with Node 22, no Bun, no dependencies, and no database. This adds a repo-managed.cursor/environment.jsonthat runs.cursor/install.sh. The script:/etc/profile.d/gratitext-toolchain.sh. The VM's PATH lists/exec-daemonand an older nvm Node before/usr/local/bin, so a symlink alone isn't enough.bun install --frozen-lockfileandbun run setup:env, and seeds a fresh database (never re-seeds an existing one)--with-depsstallThe committed file takes precedence over the personal dashboard environment for every agent on this repo.
Lint autofix (#103).
playwright/prefer-to-have-counttreats any.count()as a Locator, sobun run lint -- --fixrewroteexpect(await prisma.message.count({ where })).toBe(0)intoexpect(prisma.message).toHaveCount(0). That fails typecheck and drops thewhereclause. The rule is now off fortests/e2e/**.AGENTS.md (#104). It is now Prettier-clean, so
bun run formatdoesn't leave a stray diff. The Cloud section points at the install script instead of a hard-codedv24.16.0path that doesn't exist on the VM.Test Plan
bld-20261005-20be607f-b48e-4306-8dd1-e7aec0808f11): SUCCEEDED. The log showsNow using node v24.21.0, Bun installed, Prisma client generated,Database has been seeded, Playwright Chromium downloaded, installExit code: 0, andSnapshot ready. The previous recurring builds all failed withbun: command not found..cursor/install.shthroughenv -i … bash -lcwith the VM's default login PATH, and it exited 0. In a fresh login shell,node -vis v24.21.0, andbun/bunxresolve.eslint --fixon a probe e2e file containingexpect(await prisma.message.count({ where })).toBe(0). It now leaves the line unchanged; before, it reportedplaywright/prefer-to-have-countand rewrote it.bunx prettier --check AGENTS.mdpasses.bun run lintandbun run typecheckpass, and CI is green.Checklist