Add an ItemId newtype to identify plot items - #264
Merged
Merged
Conversation
Plot items used to be keyed by `egui::Id`, which is a globally unique id.
An item only ever has to be unique within the plot it belongs to, so this
introduces a dedicated `ItemId` for it, plus `ItemIdSet` and `ItemIdMap`
that skip rehashing an id that already is a high-entropy hash.
The builders keep the `id` name and now take `impl Hash`, so the common
`.id("my_line")` keeps compiling. It also frees `egui_plot` from `egui`'s
own id types in its public API.
`PlotItem::id`, `PlotResponse::hovered_plot_item`, `PlotMemory::hidden_items`,
`PlotMemory::hovered_legend_item` and `Legend::hidden_items` now use `ItemId`.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
View snapshot changes at kitdiff |
emilk
added
the
include in changelog
emilk
marked this pull request as ready for review
September 18, 2026 08:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plot items were keyed by
egui::Id, a supposedly globally unique id. An item only ever has to be unique within its own plot, so this adds a dedicatedItemIdnewtype wrapping a hash.