Conversation
|
View snapshot changes at kitdiff |
emilk
commented
Sep 18, 2026
emilk
commented
Sep 18, 2026
emilk
commented
Sep 18, 2026
emilk
force-pushed
the
emilk/patch-egui-main
branch
from
September 18, 2026 08:51
61b89f0 to
6f3269d
Compare
emilk
force-pushed
the
emilk/patch-egui-main
branch
from
September 18, 2026 08:58
6f3269d to
cd6d1cd
Compare
emilk
commented
Sep 18, 2026
emilk
force-pushed
the
emilk/patch-egui-main
branch
from
September 18, 2026 09:02
cd6d1cd to
c7011cf
Compare
Uncomment the `[patch.crates-io]` entries so the workspace builds against `https://github.com/emilk/egui` `main`. `egui_extras` was pinned to `=0.36.0`, which no patched version can ever satisfy, so relax it to `0.36.0` like its siblings. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
* `egui::Event::Screenshot` is gone: `ViewportCommand::Screenshot` now carries a `ScreenshotCallback`, so `save_plot` hands the image back through a shared slot instead of scanning raw events. * `Ui::id` was renamed to `Ui::scope_id`; use `Ui::make_persistent_id` instead. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
emilk
force-pushed
the
emilk/patch-egui-main
branch
from
September 18, 2026 09:17
c7011cf to
76cb363
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patches
[patch.crates-io]to build the workspace againsteguimain, plus the example fixes needed to make it compile.Upstream breaking changes adapted to:
ViewportCommand::Screenshotnow carries aScreenshotCallbackinstead of coming back as anegui::Event.Ui::idwas renamed toUi::scope_id.Note this PR is not meant to be merged as-is, since it pins the workspace to a moving branch.
Follows:
Add an
ItemIdnewtype to identify plot items #264Plot::newnow takes animpl AsIdSalt#265link_axisandlink_cursortake anId#266I have followed the instructions in the PR template
🤖 Generated with Claude Code