Update build dependencies in the Ember 7 try scenarios - #527
Merged
Merged
Conversation
The release, beta, and canary scenarios installed ember-source 7 but kept build and test packages that do not support it. - Add current ember-cli, ember-cli-babel, ember-cli-htmlbars, ember-auto-import, @ember/test-helpers, and ember-qunit to those scenarios. - Build those scenarios with the classic path (FORCE_CLASSIC), because @embroider/compat 3 cannot build ember-source 7. - Raise @embroider/macros for appEmberSatisfies, used by @ember/test-helpers 5. - Remove tracked-built-ins 3. No test used it, and it pulls in ember-cli-htmlbars 5. - Load tests in test-helper.ts, because ember-qunit 9 start() does not. - Use Node 22.22.0, because ember-cli 7 needs require(esm). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
|
alternate: converting to vite: #526 (choose one, close the other) |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the failing
ember-release,ember-beta, andember-canarytry scenarios. The test app keeps its classicember-clibuild.Those scenarios installed
ember-source7 but kept packages that do not support it. The first crash was inember-cli6.0.1, which readspaths.debugfrom the classicember-sourceaddon.Changes to the three Ember 7 scenarios:
ember-cli,ember-cli-babel,ember-cli-htmlbars,ember-auto-import,@ember/test-helpers, andember-qunit.FORCE_CLASSIC, because@embroider/compat3 looks fordist/ember-template-compiler.js, which Ember 7 does not ship.Changes for all scenarios:
@embroider/macrosto^1.21.1.@ember/test-helpers5 usesappEmberSatisfies.tracked-built-ins3. No test used it, and it pulls inember-cli-htmlbars5.loadTests()intest-helper.ts, becausestart()inember-qunit9 does not load tests.ember-cli7 needsrequire(esm), which Node 18 and 22.10 do not have.Local results:
ember-source5.3): 56 of 56ember-4.0,ember-lts-4.12,ember-lts-5.12: 56 of 56ember-release(7.3),ember-beta(7.4),ember-canary(7.5): 55 of 55.ember-qunit9 does not add itsEmber.onerrorcheck.ember-fetch-v8: 2 of 2This replaces #526, which moved the test app to Vite.
🤖 Generated with Claude Code