Build base-tests with Vite so that Ember 7 scenarios pass - #526
Closed
NullVoxPopuli-ai-agent wants to merge 1 commit into
Closed
NullVoxPopuli-ai-agent wants to merge 1 commit into
NullVoxPopuli-ai-agent wants to merge 1 commit into
Conversation
ember-source 7 is a v2 addon. The classic ember-cli build cannot load it, so the release, beta, and canary scenarios failed before the tests started. - Move base-tests to @embroider/vite and ember-cli 7.3. - Remove tracked-built-ins 3. No test used it, and its old ember-cli-htmlbars dependency breaks with Ember 7. - Remove test:prod. A production Vite build does not include tests. - Run the try scenarios on the Node version from volta (22.22.0), because Vite 7 does not support Node 18. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
|
if you like, a smaller change that doesn't convert the app to vite: (choose one, close the other) |
Contributor
|
with 527 merged, we don't need this one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the failing
ember-release,ember-beta, andember-canarytry scenarios.The build dependencies in
test-apps/base-testswere too old forember-source7:ember-cli6.0.1 readspaths.debugfrom the classicember-sourceaddon. The v2ember-source7 does not have it, so the build stopped withCannot read properties of undefined (reading 'debug').tracked-built-ins3 pulls inember-cli-htmlbars5.7.2, which crashes ontemplateCompilerwith Ember 7.Changes in
test-apps/base-tests:@embroider/viteandember-cli7.3.tracked-built-ins3. No test used it.test:prod. A production Vite build does not include the tests, and CI did not run this script.The try scenarios now use the Node version from
volta(22.22.0), because Vite 7 does not support Node 18.Local results, 55 of 55 tests pass in each run:
ember-source5.3)ember-4.0,ember-lts-4.12,ember-lts-5.12ember-release(7.3),ember-beta(7.4),ember-canary(7.5)The test count went from 56 to 55. The missing test is the
Ember.onerrorcheck thatember-qunit9 no longer adds.🤖 Generated with Claude Code