Skip to content

ci: drop the edgecommons git-auth step (dependency repo is public) #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mbreissi merged 1 commit into from
Jul 23, 2026
Merged

ci: drop the edgecommons git-auth step (dependency repo is public) #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 4 additions & 18 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ on:

jobs:
ci:
# Reusable component CI from the org defaults repo. `secrets: inherit` passes the org-level
# EDGECOMMONS_READ_TOKEN so cargo can fetch the private edgecommons git dependency. The repo must be
# added to that secret's repository allow-list (org Actions secrets, via the REST API).
# Reusable component CI from the org defaults repo (build + test + clippy -D warnings).
# `edgecommons/edgecommons` is public, so cargo fetches the git dependency anonymously and no
# token is required; `secrets: inherit` is retained but passes nothing CI now depends on.
permissions:
contents: read
uses: edgecommons/.github/.github/workflows/component-ci.yml@main
Expand Down Expand Up @@ -50,23 +50,9 @@ jobs:
run: rustup toolchain install stable --profile minimal --component llvm-tools-preview
- name: Install cargo-llvm-cov
uses: taiki-e/install-action@cargo-llvm-cov
- name: Authenticate to the private edgecommons git dependency
env:
# Same org read token the reusable workflow uses (secrets: inherit); the repo must be on
# that secret's allow-list. Rewrites the https git URL so cargo can fetch the private dep.
EDGECOMMONS_READ_TOKEN: ${{ secrets.EDGECOMMONS_READ_TOKEN }}
run: |
git config --global \
url."https://x-access-token:${EDGECOMMONS_READ_TOKEN}@github.com/edgecommons/edgecommons.git".insteadOf \
"https://github.com/edgecommons/edgecommons.git"
git config --global \
url."https://x-access-token:${EDGECOMMONS_READ_TOKEN}@github.com/edgecommons/edgecommons".insteadOf \
"https://github.com/edgecommons/edgecommons"
git config --global \
url."https://x-access-token:${EDGECOMMONS_READ_TOKEN}@github.com/".insteadOf \
"https://github.com/"
- name: Coverage gate (90% lines; composition root + main.rs + test-only messaging fake excluded)
env:
# edgecommons/edgecommons is public; cargo fetches the git dependency anonymously.
CARGO_NET_GIT_FETCH_WITH_CLI: "true"
run: >
cargo llvm-cov --locked --features streaming,streaming-file-parquet,streaming-file-avro,scripting-lua
Expand Down
Loading