ci: drop the edgecommons git-auth step (dependency repo is public)#14
Merged
Conversation
`edgecommons/edgecommons` is public, so cargo fetches the git dependency anonymously. The coverage job's "Authenticate to the private edgecommons git dependency" step rewrote the https URL with an x-access-token from EDGECOMMONS_READ_TOKEN — now unnecessary, and actively harmful once that secret is retired: it had no `|| github.token` fallback, so an empty token would inject `x-access-token:@github.com` and 401 even against the public repo. Removing the step lets the anonymous public fetch stand. The `ci` job's `secrets: inherit` is left in place (harmless; the reusable workflow guards the token with `if [ -n ]`), and its stale comment is corrected to match. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LsX7cWVGLszurNYMVwMJGo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the coverage job's
Authenticate to the private edgecommons git dependencystep.edgecommons/edgecommonsis public now, so cargo fetches the git dependency anonymously — the https-URL rewrite withx-access-token:${EDGECOMMONS_READ_TOKEN}is unnecessary.It is also the one thing that would break once
EDGECOMMONS_READ_TOKENis retired: this step had no|| github.tokenfallback, so an empty token would injectx-access-token:@github.comand 401 even against the public repo. Removing it lets the anonymous public fetch stand, clearing the way to delete the org-wide read-token secret.The
cijob'ssecrets: inheritis left in place — harmless, since the reusable workflow guards the token withif [ -n ]— and its stale comment is corrected.Part of retiring the personal-PAT
EDGECOMMONS_READ_TOKENstopgap now that every consuming CI builds the core from the public source rather than any package registry.🤖 Generated with Claude Code
https://claude.ai/code/session_01LsX7cWVGLszurNYMVwMJGo