Skip to content

Update mock bazel rules to match file names #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cameron-craig-etas wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update mock bazel rules to match file names #475

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,9 +110,9 @@ See the [demo scenario](examples/demo_verification) for an example.
**Mocks**

```
//score/launch_manager:applicationcontext_mock_cc
//score/launch_manager:lifecycle_mock_cc
//score/launch_manager:report_running_mock_cc
//score/launch_manager:mock_applicationcontext_cc
//score/launch_manager:mock_lifecycle_cc
//score/launch_manager:mock_report_running_cc
```

## Documentation
Expand Down
14 changes: 7 additions & 7 deletions score/launch_manager/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,22 +84,22 @@ lm_cc_test(
)

alias(
name = "applicationcontext_mock_cc",
actual = "//score/launch_manager/src/lifecycle_client:applicationcontext_mock",
name = "mock_applicationcontext_cc",
actual = "//score/launch_manager/src/lifecycle_client:mock_applicationcontext",
)

cc_library(
name = "lifecycle_mock_cc",
name = "mock_lifecycle_cc",
testonly = True,
deps = [
"//score/launch_manager/src/lifecycle_client:lifecycle_mock",
"//score/launch_manager/src/lifecycle_client:report_running_mock",
"//score/launch_manager/src/lifecycle_client:mock_lifecycle",
"//score/launch_manager/src/lifecycle_client:mock_report_running",
],
)

alias(
name = "report_running_mock_cc",
actual = "//score/launch_manager/src/lifecycle_client:report_running_mock",
name = "mock_report_running_cc",

@MaciejKaszynski MaciejKaszynski Aug 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are actually our public targets, I think we can just keep them in the "wrong" format. This is only used by our users so doesn't make sense to change.

actual = "//score/launch_manager/src/lifecycle_client:mock_report_running",
)

# BEGIN: Fine granular targets only needed for testing purposes
Expand Down
2 changes: 1 addition & 1 deletion score/launch_manager/src/daemon/src/process_group_manager/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ cc_library(
)

cc_library(
name = "ialive_monitor_thread_mock",
name = "mock_ialive_monitor_thread",
testonly = True,
hdrs = ["mock_alive_monitor_thread.hpp"],
include_prefix = "score/mw/launch_manager/process_group_manager",
Expand Down
6 changes: 3 additions & 3 deletions score/launch_manager/src/daemon/src/process_group_manager/details/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,11 +331,11 @@ lm_cc_test(
deps = [
"//score/launch_manager/src/daemon/src/configuration:config",
"//score/launch_manager/src/daemon/src/process_group_manager",
"//score/launch_manager/src/daemon/src/process_group_manager:ialive_monitor_thread_mock",
"//score/launch_manager/src/daemon/src/recovery_client:recovery_client_mock",
"//score/launch_manager/src/daemon/src/process_group_manager:mock_ialive_monitor_thread",
"//score/launch_manager/src/daemon/src/recovery_client:mock_recovery_client",
"//score/launch_manager/src/daemon/src/supervision_control_client:isupervision_control_notifier",
"//score/launch_manager/src/daemon/src/supervision_control_client:mock_supervision_control_notifier",
"//score/launch_manager/src/daemon/src/watchdog:i_watchdog_if_mock",
"//score/launch_manager/src/daemon/src/watchdog:mock_i_watchdog_if",
"@googletest//:gtest_main",
],
)
Expand Down
2 changes: 1 addition & 1 deletion score/launch_manager/src/daemon/src/recovery_client/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ cc_library(
)

cc_library(
name = "recovery_client_mock",
name = "mock_recovery_client",
testonly = True,
hdrs = ["mock_irecovery_client.h"],
include_prefix = "score/mw/launch_manager/recovery_client",
Expand Down
2 changes: 1 addition & 1 deletion score/launch_manager/src/daemon/src/watchdog/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ lm_cc_test(
)

cc_library(
name = "i_watchdog_if_mock",
name = "mock_i_watchdog_if",
testonly = True,
hdrs = ["mock_IWatchdogIf.hpp"],
include_prefix = "score/mw/launch_manager/watchdog",
Expand Down
16 changes: 8 additions & 8 deletions score/launch_manager/src/lifecycle_client/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ cc_library(
)

cc_library(
name = "applicationcontext_mock",
name = "mock_applicationcontext",
testonly = True,
srcs = [
"src/mock_applicationcontext.cpp",
Expand All @@ -170,7 +170,7 @@ cc_library(
)

cc_library(
name = "mw_lifecycle_manager_mock",
name = "mock_mw_lifecycle_manager",
testonly = True,
srcs = [
"src/mock_mwlifecyclemanager.cpp",
Expand All @@ -190,7 +190,7 @@ cc_library(
)

cc_library(
name = "lifecycle_mock",
name = "mock_lifecycle",
testonly = True,
srcs = [
"src/mock_lifecyclemanager.cpp",
Expand All @@ -205,17 +205,17 @@ cc_library(
strip_include_prefix = "/score/launch_manager/src/lifecycle_client/src",
visibility = ["//score/launch_manager:__subpackages__"],
deps = [
":applicationcontext_mock",
":lifecyclemanager",
":mw_lifecycle_manager_mock",
":mock_applicationcontext",
":mock_mw_lifecycle_manager",
"@googletest//:gtest",
"@score_baselibs//score/os/utils:signal",
"@score_baselibs//score/os/utils/mocklib:signal_mock",
],
)

cc_library(
name = "report_running_mock",
name = "mock_report_running",
testonly = True,
srcs = ["src/mock_report_running.cpp"],
hdrs = [
Expand All @@ -236,7 +236,7 @@ lm_cc_test(
srcs = ["src/lifecycle_mocks_UT.cpp"],
deps = [
":runapplication",
"//score/launch_manager:lifecycle_mock_cc",
"//score/launch_manager:mock_lifecycle_cc",
"@googletest//:gtest_main",
],
)
Expand All @@ -245,7 +245,7 @@ lm_cc_test(
name = "runapplication_UT",
srcs = ["src/runapplication_UT.cpp"],
deps = [
":lifecycle_mock",
":mock_lifecycle",
":runapplication",
"@googletest//:gtest_main",
],
Expand Down
Loading