Update mock bazel rules to match file names - #475
Open
cameron-craig-etas wants to merge 1 commit into
Open
Conversation
cameron-craig-etas
requested a deployment
to
workflow-approval
August 14, 2026 12:07 — with
GitHub Actions
Waiting
cameron-craig-etas
requested a deployment
to
workflow-approval
August 14, 2026 12:07 — with
GitHub Actions
Waiting
cameron-craig-etas
force-pushed
the
update-mock-names-in-bazel
branch
from
August 14, 2026 12:08
02a8b8a to
a8354af
Compare
cameron-craig-etas
requested a deployment
to
workflow-approval
August 14, 2026 12:08 — with
GitHub Actions
Waiting
cameron-craig-etas
requested a deployment
to
workflow-approval
August 14, 2026 12:08 — with
GitHub Actions
Waiting
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
cameron-craig-etas
force-pushed
the
update-mock-names-in-bazel
branch
from
August 14, 2026 12:14
a8354af to
6e3b001
Compare
cameron-craig-etas
requested a deployment
to
workflow-approval
August 14, 2026 12:14 — with
GitHub Actions
Waiting
cameron-craig-etas
requested a deployment
to
workflow-approval
August 14, 2026 12:14 — with
GitHub Actions
Waiting
cameron-craig-etas
force-pushed
the
update-mock-names-in-bazel
branch
from
August 14, 2026 12:15
6e3b001 to
644b0c3
Compare
cameron-craig-etas
requested a deployment
to
workflow-approval
August 14, 2026 12:16 — with
GitHub Actions
Waiting
cameron-craig-etas
requested a deployment
to
workflow-approval
August 14, 2026 12:16 — with
GitHub Actions
Waiting
|
The created documentation from the pull request is available at: docu-html |
cameron-craig-etas
force-pushed
the
update-mock-names-in-bazel
branch
from
August 14, 2026 12:47
644b0c3 to
f8b6dd0
Compare
cameron-craig-etas
requested a deployment
to
workflow-approval
August 14, 2026 12:47 — with
GitHub Actions
Waiting
cameron-craig-etas
requested a deployment
to
workflow-approval
August 14, 2026 12:47 — with
GitHub Actions
Waiting
cameron-craig-etas
marked this pull request as ready for review
August 14, 2026 12:55
cameron-craig-etas
requested review from
FScholPer,
MaciejKaszynski,
NicolasFussberger,
anmittag,
antonkri,
pawelrutkaq and
ramceb
as code owners
August 14, 2026 12:55
MaciejKaszynski
requested changes
Aug 14, 2026
| alias( | ||
| name = "report_running_mock_cc", | ||
| actual = "//score/launch_manager/src/lifecycle_client:report_running_mock", | ||
| name = "mock_report_running_cc", |
Contributor
There was a problem hiding this comment.
These are actually our public targets, I think we can just keep them in the "wrong" format. This is only used by our users so doesn't make sense to change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#422
This PR is a follow-up to /pull/457, where we updated the mocks filenames to match the
mock_naming convention. We're now making sure the BUILD rule names use the same format, to avoid confusion.