Add core dump extraction from container in docker plugin - #124
Open
Tejaswini-Janjale25 wants to merge 2 commits into
Open
Add core dump extraction from container in docker plugin#124Tejaswini-Janjale25 wants to merge 2 commits into
Tejaswini-Janjale25 wants to merge 2 commits into
Conversation
Tejaswini-Janjale25
marked this pull request as draft
July 20, 2026 07:42
Tejaswini-Janjale25
force-pushed
the
tj_itf_test_extract_core_changes
branch
from
July 21, 2026 10:23
1bdd4a4 to
6f63983
Compare
Tejaswini-Janjale25
marked this pull request as ready for review
July 21, 2026 10:25
soldier-sky
suggested changes
Jul 22, 2026
| "--extract-core", | ||
| action="store_true", | ||
| default=False, | ||
| help="Extract core dump files from the container before teardown.", |
There was a problem hiding this comment.
message can be improved e.g. help="Directory where extracted core dumps are stored.
Author
There was a problem hiding this comment.
I have updated the message
| return | ||
|
|
||
| for remote_path in core_paths: | ||
| local_path = os.path.join(output_base, remote_path.lstrip("/")) |
There was a problem hiding this comment.
Should we check Path.is_dir() before attempting extraction?
Author
There was a problem hiding this comment.
Added a check — if the given output directory isn't a valid directory, we log a warning and skip extraction instead of trying to download into an invalid path.
Tejaswini-Janjale25
force-pushed
the
tj_itf_test_extract_core_changes
branch
from
July 23, 2026 04:53
6f63983 to
88da2c0
Compare
soldier-sky
approved these changes
Jul 24, 2026
Tejaswini-Janjale25
force-pushed
the
tj_itf_test_extract_core_changes
branch
3 times, most recently
from
August 7, 2026 05:38
46b4e8a to
16a96e2
Compare
draganbjedov
requested changes
Aug 12, 2026
draganbjedov
left a comment
draganbjedov
left a comment
Contributor
There was a problem hiding this comment.
Using core is bad. It does not clearly states what is core. Instead core-dumps
| ) | ||
| parser.addoption("--qemu-image", action="store", help="Path to a QEMU image") | ||
| parser.addoption( | ||
| "--extract-core", |
Contributor
There was a problem hiding this comment.
Suggested change
| "--extract-core", | |
| "--extract-core-dump", |
| help="Copy core dump files from the QEMU target to the host before teardown.", | ||
| ) | ||
| parser.addoption( | ||
| "--core-output-dir", |
Contributor
There was a problem hiding this comment.
Suggested change
| "--core-output-dir", | |
| "--core-dump-output-dir", |
| "--core-output-dir", | ||
| default=os.path.join( | ||
| os.environ.get("TEST_UNDECLARED_OUTPUTS_DIR", "/tmp"), | ||
| "cores", |
Contributor
There was a problem hiding this comment.
Suggested change
| "cores", | |
| "coredumps", |
|
|
||
| def _extract_cores_from_qemu(target, output_base): | ||
| """Extract core dump files from a QEMU (QNX) target via SSH/SFTP.""" | ||
| logger.info(f"Attempting core extraction to {output_base}") |
Contributor
There was a problem hiding this comment.
Suggested change
| logger.info(f"Attempting core extraction to {output_base}") | |
| logger.info(f"Attempting core dumps extraction to {output_base}") |
| " && (ls -1 /opt/*/*.core /opt/*/*.core.gz /root/*.core /root/*.core.gz /data/*/*.core /data/*/*.core.gz 2>/dev/null || true)" | ||
| ) | ||
|
|
||
| core_paths = [line.strip() for line in output.decode().splitlines() if line.strip()] |
Contributor
There was a problem hiding this comment.
Suggested change
| core_paths = [line.strip() for line in output.decode().splitlines() if line.strip()] | |
| coredumps_paths = [line.strip() for line in output.decode().splitlines() if line.strip()] |
| ) | ||
|
|
||
| config_setting( | ||
| name = "extract_core_enabled", |
Contributor
There was a problem hiding this comment.
Suggested change
| name = "extract_core_enabled", | |
| name = "extract_core_dump_enabled", |
| # docker plugin falls back to $TEST_UNDECLARED_OUTPUTS_DIR/cores. | ||
| # Set with: bazel test --//score/itf/plugins:core_output_dir=/abs/path | ||
| string_flag( | ||
| name = "core_output_dir", |
Contributor
There was a problem hiding this comment.
Suggested change
| name = "core_output_dir", | |
| name = "core_dumps_output_dir", |
| "Defaults to $TEST_UNDECLARED_OUTPUTS_DIR/sysroot or /tmp/sysroot.", | ||
| ) | ||
| parser.addoption( | ||
| "--extract-core", |
Contributor
There was a problem hiding this comment.
Suggested change
| "--extract-core", | |
| "--extract-core-dumps", |
| help="Copy core dump files from the container to the host before teardown.", | ||
| ) | ||
| parser.addoption( | ||
| "--core-output-dir", |
Contributor
There was a problem hiding this comment.
Suggested change
| "--core-output-dir", | |
| "--core-dumps-output-dir", |
| logger.warning(f"Failed to extract {remote_path}", exc_info=True) | ||
|
|
||
|
|
||
| def _extract_core_from_container(target, output_base): |
Contributor
There was a problem hiding this comment.
Suggested change
| def _extract_core_from_container(target, output_base): | |
| def _extract_core_dumps_from_container(target, output_base): |
Author
There was a problem hiding this comment.
Hi @draganbjedov , I have made changes at all the places. And pushed the changes on the branch
Tejaswini-Janjale25
force-pushed
the
tj_itf_test_extract_core_changes
branch
2 times, most recently
from
August 12, 2026 13:09
8cd262d to
5d81f97
Compare
Tejaswini-Janjale25
force-pushed
the
tj_itf_test_extract_core_changes
branch
from
August 14, 2026 09:52
5d81f97 to
2ef825d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add optional core dump extraction from Docker containers on teardown. Generic plugin change, currently used for ITF tests in bigdata.