Enable core dump extraction for bigdata integration test - #739
Enable core dump extraction for bigdata integration test#739Tejaswini-Janjale25 wants to merge 2 commits into
Conversation
| env = {"DOCKER_HOST": ""}, | ||
| env = { | ||
| "DOCKER_HOST": "", | ||
| "TEST_UNDECLARED_OUTPUTS_DIR": "$(TEST_UNDECLARED_OUTPUTS_DIR)", |
There was a problem hiding this comment.
can you use some better name for this env var?
There was a problem hiding this comment.
This variable is already present at docker plugin, I am just reusing it
| _extend_list_in_kwargs(kwargs, "args", ["--extract-core"]) | ||
| # Only pass --core-output-dir if explicitly specified by user | ||
| # Otherwise, the plugin will use TEST_UNDECLARED_OUTPUTS_DIR/cores at runtime | ||
| if core_output_dir != None: |
There was a problem hiding this comment.
should we validate that --extract-core or --core-output-dir points to valid directory?
There was a problem hiding this comment.
added validation for core_output_dir
There was a problem hiding this comment.
Static validation is good step to identify wrong path configuration i.e. obvious invalid paths. However canonical path validation can be good but with our use-case current checks seems good enough.
360752a to
65c78c3
Compare
| git_override( | ||
| module_name = "score_itf", | ||
| remote = "https://github.com/Tejaswini-Janjale25/itf.git", | ||
| commit = "07e510ebd9429b1c726b0a7a7a404a98c3669beb", |
There was a problem hiding this comment.
For the moment blocked until the PR referenced by this commit is merged in score_itf.
| return kwargs | ||
|
|
||
| def integration_test(name, srcs, filesystem, **kwargs): | ||
| def integration_test(name, srcs, filesystem, extract_core = False, core_output_dir = None, **kwargs): |
There was a problem hiding this comment.
Making this an attribute is probably not the best idea.
I would prefer a bazel flag. But IMHO. This bool_flag should go into ITF directly.
Same for the extraction path (with a string_flag).
There was a problem hiding this comment.
I have added code changes for this comment. However waiting for merging ITF related changes as after that I can remove git_override part from here.
eclipse-score/itf#124
65c78c3 to
bee10cc
Compare
bee10cc to
aa6e222
Compare
feat(qnx): enable core dump extraction workflow
3 participants
Added changes to store core files when they are generated.