Skip to content

ci: exclude biscuit-quote from the coverage run - #347

Merged
divarvel merged 1 commit into
eclipse-biscuit:mainfrom
aojea:coverage-exclude-quote
Sep 29, 2026
Merged

divarvel merged 1 commit into
eclipse-biscuit:mainfrom
aojea:coverage-exclude-quote

Conversation

@aojea

@aojea aojea commented Sep 27, 2026

Copy link
Copy Markdown
Contributor

The Coverage job has failed on every run since at least #343, on main and on every pull request:

test test_error_msg has been running for over 60 seconds
ERROR cargo_tarpaulin: Failed to run tests: Error: Timed out waiting for test response

biscuit-quote has a single test, a trybuild compile-fail check. Under tarpaulin it spawns a nested cargo build with the coverage RUSTFLAGS, which recompiles the dependency tree from scratch and exceeds tarpaulin's 60 s per-test timeout.

Measured locally (Xeon 2.6 GHz, cold trybuild cache as on CI):

cargo test -p biscuit-quote                       test 0.33 s, total 0.47 s
cargo tarpaulin -p biscuit-quote --timeout 3600   test 123.6 s, total 137 s
reported coverage: biscuit-quote/src/lib.rs: 0/307 lines

Raising the timeout would therefore add about two minutes to the job (more on GitHub runners) and contribute no coverage: procedural macros run inside rustc, outside the traced test binary, so the crate reports zero lines either way.

Exclude the crate from the tarpaulin invocation. It is still built and its macros are still exercised by the biscuit-auth tests. With the exclusion the workflow's exact command completes in about 45 s and writes cobertura.xml.

/assign @divarvel

The Coverage job has failed on every run since at least eclipse-biscuit#343, on main
and on every pull request:

    test test_error_msg has been running for over 60 seconds
    ERROR cargo_tarpaulin: Failed to run tests: Error: Timed out waiting for test response

`biscuit-quote` has a single test, a trybuild compile-fail check. Under
tarpaulin it spawns a nested cargo build with the coverage RUSTFLAGS,
which recompiles the dependency tree from scratch and exceeds
tarpaulin's 60 s per-test timeout.

Measured locally (Xeon 2.6 GHz, cold trybuild cache as on CI):

    cargo test -p biscuit-quote                       test 0.33 s, total 0.47 s
    cargo tarpaulin -p biscuit-quote --timeout 3600   test 123.6 s, total 137 s
    reported coverage: biscuit-quote/src/lib.rs: 0/307 lines

Raising the timeout would therefore add about two minutes to the job
(more on GitHub runners) and contribute no coverage: procedural macros
run inside rustc, outside the traced test binary, so the crate reports
zero lines either way.

Exclude the crate from the tarpaulin invocation. It is still built and
its macros are still exercised by the biscuit-auth tests. With the
exclusion the workflow's exact command completes in about 45 s and
writes cobertura.xml.
@divarvel
divarvel force-pushed the coverage-exclude-quote branch from 5756c21 to f8e751e Compare September 29, 2026 19:12
@divarvel
divarvel merged commit 398e036 into eclipse-biscuit:main Sep 29, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants