Conversation
divarvel
force-pushed
the
push-xrkvrznntknx
branch
2 times, most recently
from
September 27, 2026 11:07
ca4a06b to
33a4bb3
Compare
Previously, maxTime was checked at every datalog fixpoint iteration. It is now enforced every time an expression is evaluated, including recursive evaluation. It means the `Expression` evaluation error now gains a new `Timeout` variant (which is folded into `RunLimits::Timeout`) before being visible to callers.
divarvel
force-pushed
the
push-xrkvrznntknx
branch
from
September 27, 2026 14:00
33a4bb3 to
163cc03
Compare
Contributor
|
the |
Contributor
|
submitted #347 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, maxTime was checked at every datalog fixpoint iteration. It is now enforced every time an expression is evaluated, including recursive evaluation.
It means the
Expressionevaluation error now gains a newTimeoutvariant (which is folded intoRunLimits::Timeout) before being visible to callers.Note: this is technically a breaking change:
datalog::Worldis modifiedExpressionerror type gains a new variantThat being said, those types should not be directly used by callers