Inverted null check in biscuit-capi string drop - #343
Merged
Merged
Conversation
divarvel
pushed a commit
to aojea/biscuit-rust
that referenced
this pull request
Sep 29, 2026
The Coverage job has failed on every run since at least eclipse-biscuit#343, on main and on every pull request: test test_error_msg has been running for over 60 seconds ERROR cargo_tarpaulin: Failed to run tests: Error: Timed out waiting for test response `biscuit-quote` has a single test, a trybuild compile-fail check. Under tarpaulin it spawns a nested cargo build with the coverage RUSTFLAGS, which recompiles the dependency tree from scratch and exceeds tarpaulin's 60 s per-test timeout. Measured locally (Xeon 2.6 GHz, cold trybuild cache as on CI): cargo test -p biscuit-quote test 0.33 s, total 0.47 s cargo tarpaulin -p biscuit-quote --timeout 3600 test 123.6 s, total 137 s reported coverage: biscuit-quote/src/lib.rs: 0/307 lines Raising the timeout would therefore add about two minutes to the job (more on GitHub runners) and contribute no coverage: procedural macros run inside rustc, outside the traced test binary, so the crate reports zero lines either way. Exclude the crate from the tarpaulin invocation. It is still built and its macros are still exercised by the biscuit-auth tests. With the exclusion the workflow's exact command completes in about 45 s and writes cobertura.xml.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.