Skip to content

Drop the shipped-config assertion about grobid_custom_hybrid #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
de-code merged 1 commit into from
Aug 17, 2026
Merged

Drop the shipped-config assertion about grobid_custom_hybrid #694

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions tests/config/config_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
_deep_merge,
_resolve_sequence_model_profile
)
from sciencebeam_parser.resources.default_config import DEFAULT_CONFIG_FILE


MINIMAL_PROFILE_CONFIG = {
Expand Down Expand Up @@ -293,12 +292,3 @@ def test_should_override_bool_value_with_env_var(
config = AppConfig.load_yaml(str(config_path))
config = config.apply_environment_variables()
assert config.props['key1'] is False


class TestDefaultConfigProfiles:
def _resolve_models(self, profile_name: str) -> dict:
config = AppConfig.load_yaml(DEFAULT_CONFIG_FILE)
return config.resolve_profile(profile_name)['models']

def test_grobid_custom_hybrid_inherits_every_grobid_crf_model(self):
assert self._resolve_models('grobid_custom_hybrid') == self._resolve_models('grobid_crf')
Loading