Drop the shipped-config assertion about grobid_custom_hybrid - #694
Merged
Conversation
It asserted that grobid_custom_hybrid resolves to exactly what grobid_crf resolves to, which describes the config rather than any behaviour: the first custom model the profile takes on makes it fail, so a config change would have to arrive with a test change. What it was there to show - that extends inherits the base and lets a profile state only its differences - is already covered by profile_b_extended in MINIMAL_PROFILE_CONFIG, and by the seven cases in TestResolveSequenceModelProfile, none of which a model swap disturbs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of https://github.com/eLifePathways/ScienceBeam2.0/issues/113
It asserted that grobid_custom_hybrid resolves to exactly what grobid_crf resolves to, which describes the config rather than any behaviour: the first custom model the profile takes on makes it fail, so a config change would have to arrive with a test change.
What it was there to show - that extends inherits the base and lets a profile state only its differences - is already covered by profile_b_extended in MINIMAL_PROFILE_CONFIG, and by the seven cases in
TestResolveSequenceModelProfile, none of which a model swap disturbs.