Skip to content

feat(shared): read the filesystem-only-checkpoint fallback from FILESYSTEM_ONLY_CHECKPOINT #3744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
enjoycgr wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(shared): read the filesystem-only-checkpoint fallback from FILESYSTEM_ONLY_CHECKPOINT #3744

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/ARCHITECTURE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1061,7 +1061,8 @@ sequenceDiagram
- **Filesystem-only checkpoint**: `memory: false` on snapshot-template creation exports the
rootfs and no memfile, resumes the same Firecracker process, and produces a template whose
sandboxes cold-boot; the source keeps running. Routed by its own flag,
`filesystem-only-checkpoint`, independent of `in-place-checkpoint` (no memory is exported, so
`filesystem-only-checkpoint` (`FILESYSTEM_ONLY_CHECKPOINT` for a deployment without
LaunchDarkly), independent of `in-place-checkpoint` (no memory is exported, so
the sync-WP tracking, the Firecracker release gate and the balloon gate play no part). The
API refuses it before the sandbox leaves Running when the flag is off for the team (400,
`snapshot_filesystem_only_disabled`) or when the sandbox's node runs an orchestrator
Expand Down
6 changes: 4 additions & 2 deletions packages/shared/pkg/featureflags/flags.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,8 +262,10 @@ var (
// sync-WP tracking, the Firecracker release and the balloon that gate the
// memory in-place path play no part. Off (the default) refuses the
// request before anything is touched; there is no memory fallback, since
// the caller asked for a template that cold-boots.
FilesystemOnlyCheckpointFlag = NewBoolFlag("filesystem-only-checkpoint", false)
// the caller asked for a template that cold-boots. The fallback reads
// FILESYSTEM_ONLY_CHECKPOINT so a deployment without LaunchDarkly can turn
// it on.
FilesystemOnlyCheckpointFlag = NewBoolFlag("filesystem-only-checkpoint", envBoolOr("FILESYSTEM_ONLY_CHECKPOINT", false))

// EnvdInitHeldRequestFlag makes a start whose envd is at or above
// utils.MinEnvdVersionForHeldInit wait on one /init for its whole envd-wait budget
Expand Down