Repository navigation
Conversation
…YSTEM_ONLY_CHECKPOINT Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
enjoycgr
requested review from
ValentaTomas,
dobrac and
jakubno
as code owners
October 24, 2026 07:32
|
We require contributors to sign our Contributor License Agreement, and we don't have @enjoycgr on file. You can sign our CLA at https://e2b.dev/docs/cla . Once you've signed, post a comment here that says '@cla-bot check' |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deployments without LaunchDarkly (self-hosted, E2B Embed) can't turn on
filesystem-only-checkpoint. The flag is hardwired tofalse, socreateSnapshot({ mode: 'filesystem' })is always refused withsnapshot_filesystem_only_disabled. This adds the same env fallback thatPAUSE_REFUSAL_RESTOREandCREATE_MEMORY_REFUSALalready have:Both the API (
snapshot_template_create.go) and the orchestrator (server/sandboxes.go) read the flag, so an operator sets the variable on both. Unset, nothing changes.docs/ARCHITECTURE.mdnames the variable, the same way it does for the neighbouring flags.Embed is not changed here. Its compose turns on reliability knobs unconditionally, and whether to expose this one is the maintainers' call.
Evidence
Before: on a self-hosted stack without LaunchDarkly, a filesystem-only snapshot request gets 400
snapshot_filesystem_only_disabled. The only workaround is patching the default totrueand rebuilding the API and orchestrator. I run that patch on a self-hosted Amp orb host, where filesystem-only project snapshots save in under a second and new sandboxes cold-boot from them.After: with
FILESYSTEM_ONLY_CHECKPOINTset, the flag's fallback comes from the env:FILESYSTEM_ONLY_CHECKPOINTtrue/1false/garbagego test -race ./pkg/featureflags/...(inpackages/shared):ok.gofmt -l: clean.make lintwas not run locally.Merge Danger
Door: two-way
Behaviour changes only when the variable is set, and LaunchDarkly values still take precedence where LaunchDarkly is configured.
Blast Radius: minimal
The existing placement floor (
0.16.202609301732) still refuses nodes too old to run the feature.🤖 Generated with Claude Code