Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,13 @@ interface BrowserBaselineTests {
baselineYear?: number | null
baselineReason?: string | string[] | null
baselineFeatureCount?: NonNullable<
FrameworkResult['browserBaselineTests']
FrameworkResult['browserBaseline']
>['baselineFeatureCount']
}

interface VersionStats {
frameworkVersion?: string
browserBaselineTests?: BrowserBaselineTests
browserBaseline?: BrowserBaselineTests
}

interface Props {
Expand All @@ -35,7 +35,7 @@ const columns = [
] satisfies TableColumn[]

const data = versions.flatMap((version) => {
const baseline = version.browserBaselineTests
const baseline = version.browserBaseline
if (baseline == null) return []

const featureCount = baseline.baselineFeatureCount?.value
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@ import ComparisonBarChart from '../../components/ComparisonBarChart.astro'
import ComparisonLineChart from '../../components/ComparisonLineChart.astro'

type DependencyMetric =
| 'allDependencies'
| 'devDependencies'
| 'prodDependencies'
| 'duplicateDependencies'
| 'totalDependencyCount'
| 'developmentDependencyCount'
| 'productionDependencyCount'
| 'duplicateDependencyCount'

function getDependencyChartData(metric: DependencyMetric) {
return starterStats
Expand Down Expand Up @@ -58,7 +58,7 @@ function getDependencyCharts(metric: DependencyMetric, title: string) {
}

const { bar, line } = getDependencyCharts(
'duplicateDependencies',
'duplicateDependencyCount',
'First-Party Duplicate Dependencies',
)
const options = [
Expand Down
4 changes: 2 additions & 2 deletions packages/docs/src/benchmarks/initial-load/Details.astro
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@ import StackedAreaChart from '../../components/StackedAreaChart.astro'
import { initialLoadSeries } from '../../lib/prepare-chart'
import { prepareInitialLoadResources } from '../../lib/initial-load'
interface Props {
versions: { frameworkVersion?: string; initialLoadTests?: InitialLoadStats }[]
versions: { frameworkVersion?: string; initialLoad?: InitialLoadStats }[]
}
const data = Astro.props.versions.flatMap((version) => {
const resources = version.initialLoadTests?.resources
const resources = version.initialLoad?.resources
if (!resources) return []
const values = prepareInitialLoadResources(resources)
return [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ import LighthouseRenderedInteractionCharts from '../shared/LighthouseRenderedInt

<LighthouseClientSideRenderedFPChart />
<LighthouseClientSideRenderedFCPChart />
<LighthouseRenderedInteractionCharts testsKey="clientSideRenderedTests" />
<LighthouseRenderedInteractionCharts testsKey="clientSideRendered" />
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ import LighthouseRenderedInteractionCharts from '../shared/LighthouseRenderedInt

<LighthouseServerSideRenderedFPChart />
<LighthouseServerSideRenderedFCPChart />
<LighthouseRenderedInteractionCharts testsKey="serverSideRenderedTests" />
<LighthouseRenderedInteractionCharts testsKey="serverSideRendered" />
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ import VersionLineChart from '../../components/VersionLineChart.astro'

interface Props {
versions: ChartMeasurement[]
testsKey?: 'ssrLoadTests' | 'ssrRouterLinkLoadTests'
testsKey?: 'ssrLoad' | 'ssrRouterLinkLoad'
}

const { versions, testsKey = 'ssrLoadTests' } = Astro.props
const { versions, testsKey = 'ssrLoad' } = Astro.props
const hasMeasurements = versions.some(
(version) =>
version != null && typeof version === 'object' && testsKey in version,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { getRenderedInteractionBreakdownData } from '../../lib/prepare-chart'
import InteractionBreakdownChart from './InteractionBreakdownChart.astro'

interface Props {
testsKey: 'clientSideRenderedTests' | 'serverSideRenderedTests'
testsKey: 'clientSideRendered' | 'serverSideRendered'
}

const { testsKey } = Astro.props
Expand Down
2 changes: 1 addition & 1 deletion packages/docs/src/benchmarks/ssr-load-test/Details.astro
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,4 @@ type Props = Omit<ComponentProps<typeof Charts>, 'testsKey'>
<Description />
<slot />

<Charts {...Astro.props} testsKey="ssrLoadTests" />
<Charts {...Astro.props} testsKey="ssrLoad" />
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import ComparisonLineChart from '../../components/ComparisonLineChart.astro'
interface Props {
testsKey?: SSRLoadKey
}
const { testsKey = 'ssrLoadTests' } = Astro.props
const { testsKey = 'ssrLoad' } = Astro.props
const byConnections = prepareSSRLatencyByConnections(
ssrRequestThroughputStats,
'p75Latency',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import ComparisonLineChart from '../../components/ComparisonLineChart.astro'
interface Props {
testsKey?: SSRLoadKey
}
const { testsKey = 'ssrLoadTests' } = Astro.props
const { testsKey = 'ssrLoad' } = Astro.props
const byConnections = prepareSSRLatencyByConnections(
ssrRequestThroughputStats,
'p90Latency',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import ComparisonLineChart from '../../components/ComparisonLineChart.astro'
interface Props {
testsKey?: SSRLoadKey
}
const { testsKey = 'ssrLoadTests' } = Astro.props
const { testsKey = 'ssrLoad' } = Astro.props
const byConnections = prepareSSRLatencyByConnections(
ssrRequestThroughputStats,
'p99Latency',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,4 @@ type Props = Omit<ComponentProps<typeof Charts>, 'testsKey'>
<Description />
<slot />

<Charts {...Astro.props} testsKey="ssrRouterLinkLoadTests" />
<Charts {...Astro.props} testsKey="ssrRouterLinkLoad" />
2 changes: 1 addition & 1 deletion packages/docs/src/components/test/fixtures.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ const barChart = (): ComponentProps<typeof ComparisonBarChart> =>
...framework,
frameworkVersion: '1.0.0',
install: {
installTime: { median: 1000 },
duration: { median: 1000 },
nodeModulesSize: { value: framework.sizeMb * MB, unit: 'bytes' },
},
})),
Expand Down
6 changes: 3 additions & 3 deletions packages/docs/src/content/docs/run-time.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -54,12 +54,12 @@ import { Content as SSRRouterLinkLoadDescription } from '../../benchmarks/ssr-ro

### P99 Latency

<SSRLoadP99Charts testsKey="ssrRouterLinkLoadTests" />
<SSRLoadP99Charts testsKey="ssrRouterLinkLoad" />

### P90 Latency

<SSRLoadP90Charts testsKey="ssrRouterLinkLoadTests" />
<SSRLoadP90Charts testsKey="ssrRouterLinkLoad" />

### P75 Latency

<SSRLoadP75Charts testsKey="ssrRouterLinkLoadTests" />
<SSRLoadP75Charts testsKey="ssrRouterLinkLoad" />
Loading
Loading