Repository navigation
Naming Consistancy - #843
Merged
Merged
Naming Consistancy #843
Conversation
Contributor
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
framework-performance | 9d2487f | Commit Preview URL Branch Preview URL |
Nov 12 2026, 06:21 AM |
43081j
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While improving the schema for ingestion @dreyfus92 pointed out some naming inconsistencies and hot dam was he right. Best to get on these ASAP before we add more tests.
durationMs,warmupDurationMs,stageDurationMs, andrecoveryMswere left out as I am going to move those to configuration file in a follow up PR.This PR can seem huge due to migrating the JSON files so to make it easy review only these commits:
Basically we renamed the following keys to:
coldBuildTime->coldBuildwarmBuildTime->warmBuilddevServerStartTime->devServerinitialLoadTests->initialLoadssrRequestThroughputTests->ssrRequestThroughputssrLoadTests->ssrLoadssrRouterLinkLoadTests->ssrRouterLinkLoadclientSideRenderedTests->clientSideRenderedserverSideRenderedTests->serverSideRenderedbrowserBaselineTests->browserBaselinedependencyScan->dependenciescorejs->coreJs(result key and benchmark name)installTime->durationtime->duration(build and dev server)elapsedTime->duration(raw SSR load stages)operationThroughput->requestThroughputsamples->requests(SSR request throughput iterations and legacy results)samples->totalRequests(current SSR request throughput summaries)samples->iterations(legacy browser rendering)minimumSamples->minimumRequestswarmupMinimumSamples->warmupMinimumRequestsworkers->connectionsworkerStages->stageConnectionsfcp->firstContentfulPaintprodDependencies->productionDependencyCountdevDependencies->developmentDependencyCount(benchmark count)allDependencies->totalDependencyCountduplicateDependencies->duplicateDependencyCountdepInstallSize->dependencyInstallSizepackagesScanned->scannedPackageCountpackagesDeclaringNodeEngine->packagesDeclaringNodeEngineCount