Skip to content

Clean key names #841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexanderKaran merged 5 commits into from
Nov 12, 2026
Merged

Clean key names #841

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b57a68d
Updated Schema
AlexanderKaran Nov 12, 2026
ed3507b
Updated Benchmarks
AlexanderKaran Nov 12, 2026
37f2e0d
Updated Past Results
AlexanderKaran Nov 12, 2026
6cec356
Updated consumers
AlexanderKaran Nov 12, 2026
8ee1c26
Merge branch 'main' into clean-key-names
AlexanderKaran Nov 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions packages/docs/src/benchmarks/shared/FrameworkSSRLoadVersionCharts.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,33 +26,33 @@ const hasMeasurements = versions.some(
/>

<VersionLineChart
{...prepareSSRLatencyHistory(versions, 25, 'p99LatencyMs', testsKey)}
{...prepareSSRLatencyHistory(versions, 25, 'p99Latency', testsKey)}
/>
<VersionLineChart
{...prepareSSRLatencyHistory(versions, 50, 'p99LatencyMs', testsKey)}
{...prepareSSRLatencyHistory(versions, 50, 'p99Latency', testsKey)}
/>
<VersionLineChart
{...prepareSSRLatencyHistory(versions, 100, 'p99LatencyMs', testsKey)}
{...prepareSSRLatencyHistory(versions, 100, 'p99Latency', testsKey)}
/>

<VersionLineChart
{...prepareSSRLatencyHistory(versions, 25, 'p90LatencyMs', testsKey)}
{...prepareSSRLatencyHistory(versions, 25, 'p90Latency', testsKey)}
/>
<VersionLineChart
{...prepareSSRLatencyHistory(versions, 50, 'p90LatencyMs', testsKey)}
{...prepareSSRLatencyHistory(versions, 50, 'p90Latency', testsKey)}
/>
<VersionLineChart
{...prepareSSRLatencyHistory(versions, 100, 'p90LatencyMs', testsKey)}
{...prepareSSRLatencyHistory(versions, 100, 'p90Latency', testsKey)}
/>

<VersionLineChart
{...prepareSSRLatencyHistory(versions, 25, 'p75LatencyMs', testsKey)}
{...prepareSSRLatencyHistory(versions, 25, 'p75Latency', testsKey)}
/>
<VersionLineChart
{...prepareSSRLatencyHistory(versions, 50, 'p75LatencyMs', testsKey)}
{...prepareSSRLatencyHistory(versions, 50, 'p75Latency', testsKey)}
/>
<VersionLineChart
{...prepareSSRLatencyHistory(versions, 100, 'p75LatencyMs', testsKey)}
{...prepareSSRLatencyHistory(versions, 100, 'p75Latency', testsKey)}
/>
</>
) : (
Expand Down
2 changes: 1 addition & 1 deletion packages/docs/src/benchmarks/shared/InteractionHistoryChart.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ const { title, data } = Astro.props
{title}
data={data.map((datum) => ({
name: datum.name,
total: datum.interactionLatencyMs,
total: datum.interactionLatency,
values: Object.fromEntries(
INTERACTION_PHASES.map(({ key }) => [key, datum[key]]),
),
Expand Down
3 changes: 1 addition & 2 deletions packages/docs/src/benchmarks/shared/LighthouseRenderedInteractionCharts.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@ interface Props {
const { testsKey } = Astro.props
const data = getRenderedInteractionBreakdownData(testsKey).sort(
(a, b) =>
a.interactionLatencyMs - b.interactionLatencyMs ||
a.name.localeCompare(b.name),
a.interactionLatency - b.interactionLatency || a.name.localeCompare(b.name),
)
---

Expand Down
2 changes: 1 addition & 1 deletion packages/docs/src/benchmarks/ssr-load-test/SSRLoadP75Charts.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ interface Props {
const { testsKey = 'ssrLoadTests' } = Astro.props
const byConnections = prepareSSRLatencyByConnections(
ssrRequestThroughputStats,
'p75LatencyMs',
'p75Latency',
testsKey,
)

Expand Down
2 changes: 1 addition & 1 deletion packages/docs/src/benchmarks/ssr-load-test/SSRLoadP90Charts.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ interface Props {
const { testsKey = 'ssrLoadTests' } = Astro.props
const byConnections = prepareSSRLatencyByConnections(
ssrRequestThroughputStats,
'p90LatencyMs',
'p90Latency',
testsKey,
)

Expand Down
2 changes: 1 addition & 1 deletion packages/docs/src/benchmarks/ssr-load-test/SSRLoadP99Charts.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ interface Props {
const { testsKey = 'ssrLoadTests' } = Astro.props
const byConnections = prepareSSRLatencyByConnections(
ssrRequestThroughputStats,
'p99LatencyMs',
'p99Latency',
testsKey,
)

Expand Down
4 changes: 2 additions & 2 deletions packages/docs/src/components/test/fixtures.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ const barChart = (): ComponentProps<typeof ComparisonBarChart> =>
...framework,
frameworkVersion: '1.0.0',
install: {
installTimeMs: { median: 1000 },
nodeModulesSizeBytes: { value: framework.sizeMb * MB, unit: 'bytes' },
installTime: { median: 1000 },
nodeModulesSize: { value: framework.sizeMb * MB, unit: 'bytes' },
},
})),
)
Expand Down
Loading
Loading