Skip to content

Clean key names - #841

Merged
AlexanderKaran merged 5 commits into
mainfrom
clean-key-names
Nov 12, 2026
Merged

AlexanderKaran merged 5 commits into
mainfrom
clean-key-names

Conversation

@AlexanderKaran

Copy link
Copy Markdown
Collaborator

Now each benchmark has unit inside it we can drop the unit names from some of the keys. This can seem like a large PR due to the migration of existing results you only need to review:

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
framework-performance 8ee1c26 Commit Preview URL

Branch Preview URL
Nov 12 2026, 04:19 AM

@dreyfus92 dreyfus92 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small naming thought: we now have coldBuildDuration / warmBuildDuration next to installTime / time / elapsedTime, might be worth picking one of time or duration while we're renaming anyway. config keys like durationMs / warmupDurationMs still have the suffix, which i guess is on purpose since they're not measurements?

@AlexanderKaran

AlexanderKaran commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator Author

@dreyfus92 I think constancy in naming approach should be its own PR to help make it clear what choices were made i.e this part

small naming thought: we now have coldBuildDuration / warmBuildDuration next to installTime / time / elapsedTime, might be worth picking one of time or duration while we're renaming **anyway.**

As for durationMs / warmupDurationMs still have the suffix yes this is on purpose they are config sets up, storing what was done for warm up and stuff. However maybe we could rip these out and they can just be part of the config here:

packages/results/src/measurements.ts

They are unlikely to change and if they ever do you can just check the git history would keep the results slimmer as well. Would also be its own PR

@dreyfus92 dreyfus92 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree on the naming, makes sense as its own pr so the choices are clear ✌🏻

@AlexanderKaran
AlexanderKaran merged commit 11415e7 into main Nov 12, 2026
97 checks passed
@AlexanderKaran
AlexanderKaran deleted the clean-key-names branch November 12, 2026 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants