Repository navigation
Clean key names - #841
Clean key names#841
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
framework-performance | 8ee1c26 | Commit Preview URL Branch Preview URL |
Nov 12 2026, 04:19 AM |
dreyfus92
left a comment
There was a problem hiding this comment.
small naming thought: we now have coldBuildDuration / warmBuildDuration next to installTime / time / elapsedTime, might be worth picking one of time or duration while we're renaming anyway. config keys like durationMs / warmupDurationMs still have the suffix, which i guess is on purpose since they're not measurements?
|
@dreyfus92 I think constancy in naming approach should be its own PR to help make it clear what choices were made i.e this part As for
They are unlikely to change and if they ever do you can just check the git history would keep the results slimmer as well. Would also be its own PR |
dreyfus92
left a comment
There was a problem hiding this comment.
agree on the naming, makes sense as its own pr so the choices are clear ✌🏻
Now each benchmark has unit inside it we can drop the unit names from some of the keys. This can seem like a large PR due to the migration of existing results you only need to review: