Repository navigation
fix(run-agent,issue-triage): run triage on the agent:triage label, and fail when the agent never ran - #243
Open
azlekov wants to merge 1 commit into
Open
fix(run-agent,issue-triage): run triage on the agent:triage label, and fail when the agent never ran#243azlekov wants to merge 1 commit into
azlekov wants to merge 1 commit into
Conversation
…d fail when the agent never ran Tag mode re-checks the trigger even with a prompt, and on issues/labeled compares the label to label_trigger, default `claude`. issue-triage runs in tag mode for its progress comment, so the agent:triage label skipped the agent and the job passed green. - run-agent passes the routed event's own label as label_trigger when a prompt is set. - run-agent warns "Agent never ran" on a self-skip, sets a new self-skipped output, and fails with a new fail-on-self-skip input. An edited or deleted comment is refused by design, not a skip. - issue-triage sets fail-on-self-skip: an issue triaged before keeps its old Triage state, so the state check alone passed a run that never happened. - issue-triage clears agent:triage in a final step instead of asking the agent to. Only a 404 is silent, and a cancelled run clears it only when the label started it. Closes #242 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
azlekov
force-pushed
the
fix/agent-label-trigger
branch
from
November 16, 2026 14:08
87c3c46 to
df64adf
Compare
This was referenced Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #242.
agent:triagenow runs triage. A run where claude-code-action skips itself warns, and fails the triage job. The label is cleared on every path.Cause
issue-triagesetstrack-progress, so claude-code-action runs in tag mode. Tag mode re-checks the trigger even with a prompt. Onissues/labeledit compares the label tolabel_trigger, defaultclaude, and on a mismatch it skips itself and reports success. Agent mode does not check, so only triage was affected.Changes
run-agentpasses the routed event's own label aslabel_trigger, only when a prompt is set. The gate already chose the label. In pure tag mode the label is the request, so the default stays.run-agentwarnsAgent never ranon a self-skip and sets a newself-skippedoutput. It still writes noAgent runnotice, since a skip is not a run.skippedkeeps its meaning (workflow-mismatch), becausedeps-verifyreads it that way.run-agentgainsfail-on-self-skip(defaultfalse). With it, a self-skip fails the step. An edited or deleted comment is not a self-skip: the action refuses it by design, ahead of any trigger.issue-triagesetsfail-on-self-skip. ItsTriage statecheck alone cannot catch a skip, because an issue triaged before keeps its old state. That is how the broken run passed.issue-triageclearsagent:triagein a final step instead of asking the agent to. Only a 404 is silent; any other failure warns that the request stays on. A cancelled run clears it only when the label started it, so a run superseded by the labeled one does not strip its label, while a timed-out labeled run still frees it.Tests
actions/run-agent/test.sh: 126 passed, 0 failed. The new cases failed before the fix, and a mutation check confirmed that each guards its line:self-skipped=trueon a self-skip, not on a failure, not on an edited comment, and does on a new commentlabel_triggercarries the routed label,fail-on-self-skipdefaults off and fails the last step, and triage sets itgh, stays quiet on success and on a 404 and warns on a 403hk check --allis clean.Rollout
The fix reaches the canary repos on
@nexton merge, and everyone else afterPromote. To verify, applyagent:triageto a test issue in a canary repo. Triage should run and setTriage state, and the label should disappear.🤖 Generated with Claude Code