Repository navigation
Conversation
…quest-label One composite action now removes a request label: percent-encoded, a 404 is silent, any other failure is a ::warning that the request stays on, and the step never fails. pr-review, issue-implement, issue-decompose and pr-iterate call it with their own `if:`; judge-verdict calls its clear.sh from inside its sweep loop. Why: the hand-written copies had drifted, most to `|| true`, so a 403 read as "label absent". GitHub emits no labeled event for a label already present, so a silently failed removal is a request that can never be made again. Rejected: routing deps-verify's removals here. Those are deps:* verdict labels, records rather than requests, and deps-verify never removes agent:review. Refs: #244 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #244.
What
A new composite action,
actions/clear-request-label, is now the only code that removes anagent:*request label.::warning title=<label> not removed::#N keeps <label>, so the request stays on ….numbertakes one or more whitespace-separated numbers, which is whatpr-iterate's conflict relay needs.pr-review.ymlagent:reviewalways()issue-decompose.ymlagent:decomposealways()issue-implement.ymlgateagent:implementlabeledevent. The check step now setsclear=true, and the step right after it removes the labelissue-implement.ymlreportagent:implementalways(), now its own step after the reportpr-iterate.ymldecideagent:iterateland,handoff,give-up,relay, with the App token as before. It runs beforeact, so a relay's re-add is still a freshlabeledeventpr-iterate.ymlconflict relayagent:iteratepr-iterate.ymlupdate hand-offagent:iteratealways() && pushed != 'true'actions/judge-verdict/verdict.shagent:judge../clear-request-label/clear.shdirectly, because its sweep clears from inside a loop (the same pattern asdependency-checkcallingagent-gate/gate.sh)Why
GitHub emits no
labeledevent for a label that is already on, so a request label that never comes off can't be asked for again. Most of the hand-written copies ended in|| true, which made a 403 look like "label absent".pr-reviewprinted "agent:review was not on this PR" for any failure at all.Not changed
deps-verify.ymlaround L845 removes thedeps:verified/deps:fixed/deps:needs-manualverdict labels. Those are records, not requests, and deps-verify never removesagent:review, so it stays out of this PR.Pending: issue-triage
issue-triage.yml's "Clear the request label" step only exists in #243, which is still open. Once #243 merges, this branch will be rebased on it and that step switched to the action, withif: always() && (!cancelled() || github.event.action == 'labeled')and numberinputs.issue-number || github.event.issue.number. This PR stays a draft until then. After the rebase, thetest.shguard fails until that step is converted.Tests
actions/clear-request-label/test.shstubsghand covers:action.ymlpasses each input throughagent:*removal written outside the action. Againstmainit flags all seven hand-written sites.hk check --allpasses.self-test.yml, run locally withPYTHONPATH=.github/selftest: 42 of 42 pass, the same result as onmain.actions/*/test.shandscripts/*.test.shpasses locally.The new action is referenced as
@v1, like every internal ref. The channel commit pins it to the release that adds it.🤖 Generated with Claude Code