Skip to content

chore: update login to mention OATs (alternative) - #7538

Closed
thaJeztah wants to merge 2 commits into
docker:masterfrom
thaJeztah:pr_7532_suggestions
Closed

thaJeztah wants to merge 2 commits into
docker:masterfrom
thaJeztah:pr_7532_suggestions

Conversation

@thaJeztah

Copy link
Copy Markdown
Member

Shorten the login flag descriptions and hints for access tokens, and consolidate PAT and OAT authentication instructions in the CLI reference.

Release notes (optional)

A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Maria Ines Parnisari <maria.parnisari@docker.com>
@codecov-commenter

codecov-commenter commented Nov 20, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
cli/command/registry.go 0.00% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

@docker-agent docker-agent left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment: 🟡 NEEDS ATTENTION

Comment thread cli/command/registry.go Outdated
out.PrintNote("A Personal Access Token (PAT) can be used instead.\n" +
"To create a PAT, visit " + aec.Underline.Apply("https://app.docker.com/settings") + "\n\n")
out.PrintNote("Use a personal access token (PAT) or organization access token (OAT) instead of a password.\n" +
"When using an OAT, use your organization name as the username.\n" +

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[medium] OAT username hint appears after the username has already been collected

The newly added note at the password-prompt stage includes:

"When using an OAT, use your organization name as the username."

However, this hint is printed after the username has already been committed — either entered interactively (line ~139) or supplied via --username. By the time a user reads this instruction they cannot act on it without aborting and re-running the command.

The patOrOatSuggest string shown before the username prompt already mentions PAT/OAT tokens; the organization-name guidance should be incorporated there (or placed before the Username: prompt) so users see it in time to enter the correct username.

Confidence Score
🟢 strong 100/100

Shorten the login flag descriptions and hints for access tokens,
and consolidate PAT and OAT authentication instructions in the
CLI reference.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah

Copy link
Copy Markdown
Member Author

This is now included in #7532

@thaJeztah
thaJeztah deleted the pr_7532_suggestions branch November 20, 2026 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants