Repository navigation
Conversation
Signed-off-by: Maria Ines Parnisari <maria.parnisari@docker.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🟡 NEEDS ATTENTION
| out.PrintNote("A Personal Access Token (PAT) can be used instead.\n" + | ||
| "To create a PAT, visit " + aec.Underline.Apply("https://app.docker.com/settings") + "\n\n") | ||
| out.PrintNote("Use a personal access token (PAT) or organization access token (OAT) instead of a password.\n" + | ||
| "When using an OAT, use your organization name as the username.\n" + |
There was a problem hiding this comment.
[medium] OAT username hint appears after the username has already been collected
The newly added note at the password-prompt stage includes:
"When using an OAT, use your organization name as the username."
However, this hint is printed after the username has already been committed — either entered interactively (line ~139) or supplied via --username. By the time a user reads this instruction they cannot act on it without aborting and re-running the command.
The patOrOatSuggest string shown before the username prompt already mentions PAT/OAT tokens; the organization-name guidance should be incorporated there (or placed before the Username: prompt) so users see it in time to enter the correct username.
| Confidence | Score |
|---|---|
| 🟢 strong | 100/100 |
6927284 to
6b7b3fe
Compare
Shorten the login flag descriptions and hints for access tokens, and consolidate PAT and OAT authentication instructions in the CLI reference. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
6b7b3fe to
c2f7c16
Compare
|
This is now included in #7532 |
Shorten the login flag descriptions and hints for access tokens, and consolidate PAT and OAT authentication instructions in the CLI reference.
Release notes (optional)
A picture of a cute animal (not mandatory but encouraged)