Skip to content

chore: update login to mention OATs - #7532

Merged
thaJeztah merged 1 commit into
docker:masterfrom
miparnisari:login-mention-oats
Nov 20, 2026
Merged

thaJeztah merged 1 commit into
docker:masterfrom
miparnisari:login-mention-oats

Conversation

@miparnisari

Copy link
Copy Markdown
Contributor

Summary

Update docker login to mention OATs.

Release notes (optional)

Update `docker login` to mention OATs as an additional authentication mechanism.

A picture of a cute animal (not mandatory but encouraged)

image

@miparnisari
miparnisari requested review from a team and thaJeztah as code owners November 18, 2026 18:46

@docker-agent docker-agent left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment: 🟢 APPROVE

@codecov-commenter

codecov-commenter commented Nov 18, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
cli/command/registry.go 0.00% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

@TanvirTian

Copy link
Copy Markdown
Contributor

@miparnisari bro you need to sign the DCO

@thaJeztah thaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! (sorry for the delay); I left a comment, and will open a PR in our docs to update the redirect.

Still slightly looking if we can somehow keep the information shorter for the flag descriptions, because it becomes a bit difficult to navigate with all the different combinations, but no good suggestions (yet)

docker login --help
Usage:  docker login [OPTIONS] [SERVER]

Authenticate to a registry.
Defaults to Docker Hub if no server is specified.

Options:
  -p, --password string   Password, Personal Access Token (PAT), or Organization Access Token (OAT), or "-" to read from stdin
      --password-stdin    Take the Password, Personal Access Token (PAT), or Organization Access Token (OAT) from stdin
  -u, --username string   Username, or organization name when using an Organization Access Token (OAT)

Comment thread cli/command/registry.go Outdated
Comment on lines +171 to +174
out.PrintNote("A Personal Access Token (PAT) or Organization Access Token (OAT) can be used instead.\n" +
"To create a PAT, visit " + aec.Underline.Apply("https://app.docker.com/settings") + "\n" +
"To create an OAT, visit " + aec.Underline.Apply("https://app.docker.com") + " and select your organization, then Identity & auth > Access tokens.\n" +
"When using an OAT, use your organization name as the username.\n\n")

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we have https://docs.docker.com/security/access-tokens/ in our documentation now, which contains information for both PAT and OAT.

I think we can update the /go/ redirect to that page, then all instructions are available, which means we can use a permalink (the /go/ redirect), and make sure the information is always up-to-date if it changes.

It currently points to PAT, so we can update that; https://github.com/docker/docs/blob/4089da36f9f99a51a8afd6c69b211fdd7db18b5f/data/redirects.yml#L18-L19

"/security/access-tokens/personal-access-tokens/":
  - /go/access-tokens/

@thaJeztah

Copy link
Copy Markdown
Member

@thaJeztah

Copy link
Copy Markdown
Member

@miparnisari I played a bit with alternatives, and opened a PR against your branch;

Also opened the combined changes as a draft PR;

Let me know what you think! If you merge miparnisari#1, my changes should show up here as well, but it's good to squash them then with your commit (we generally try to avoid "fix up" commits to keep a cleaner history).

Also more than happy to carry your changes.

miparnisari added a commit to miparnisari/cli that referenced this pull request Nov 20, 2026

@thaJeztah thaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Signed-off-by: Maria Ines Parnisari <maria.parnisari@docker.com>

@thaJeztah thaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (thanks for fixing the DCO)

@thaJeztah
thaJeztah merged commit ed1fcc8 into docker:master Nov 20, 2026
99 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants