Repository navigation
feat(file-viewer): open a markdown file's new tab as a page of the document - #849
Merged
Merged
Conversation
…cument Open in a new tab loaded the whole app again with the file viewer over it. A ?read= address now renders FileReader instead of App: the document as the page, its name and path with Open raw file and Download, no sidebar, panes or session connection. Links in the document open other files there, resolved from its folder, and Back returns. ?file= links keep opening the app with the viewer. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 40 minutes. View limit details
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Summary
Merge Risk: ⚪ Minimal · up to Standalone reader navigation is covered by the changed regression test, and no merge-blocking issue was established. Merge after normal checks. Pre-merge checks |
  |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 40.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 6 files. (2 skipped: 2… | Write docstrings for the functions missing them to satisfy the coverage threshold. |
✅ Passed checks (4 passed)
-
-
Check name Status Explanation Title check The title clearly describes the main change: opening a Markdown file in a new tab as a dedicated document page. Description check The description explains the problem, resulting behavior, implementation scope, and test coverage. The Tests section provides the required validation details, although the template heading is named "T… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
-
Full details: Docstring Coverage
-
-
Explanation
Docstring coverage is 40.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 6 files. (2 skipped: 2 unsupported.)
-
✨ Finishing Touches 💡 1
-
-
📝 Generate docstrings 💡
-
-
-
- Commit to this branch
- Create a new PR
-
-
🧪 Generate unit tests (beta)
-
-
- Commit to this branch
- Create a new PR
-
-
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
… a step above a home-relative folder Review findings (Codex, pre-merge): a reader address opened without the app's cookie showed only "could not be opened": the tab asks the bridge's health first and shows the app's sign-in gate when it is locked. A link above a ~/ document's folder was folded into ~/, naming another file; the step up is kept for the PC to expand. The regression's request list is checked by its length, which does not narrow the array for the typecheck. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
devswha
added a commit
that referenced
this pull request
Oct 12, 2026
## Change Release 0.4.8, from main at ca6db6e (20 PRs since v0.4.7: the 0.4.7 mobile walk-through fixes, two contributor PRs and the revived #793). - `package.json` and `herdr-plugin.toml`: 0.4.8. - CHANGELOG: `[Unreleased]` becomes `[0.4.8] - 2026-10-12`, with the compare links. Twelve entries that had no PR link get theirs (#835 #837 #838 #840 #842 #843 #844+#848 #845 #847 #849 #851 #852). A Maintenance line says the remote-PC runtime is now version 27. - `release-summaries.json`: 0.4.8 in en/ko/ja/zh/tr (3 new, 6 improved, 8 fixed). The Turkish lines are not checked by a native speaker. - `REMOTE_BUNDLE_VERSION` 26 -> 27: #836 adds the `pending-hold` server feature and #787 serves precompressed assets, so `remote-v27` is published before the app release. Every PR merged since v0.4.7 is linked in the section: #787 #788 #793 #835 #836 #837 #838 #839 #840 #841 #842 #843 #844 #845 #846 #847 #848 #849 #851 #852. ## Validation - `bun scripts/release-notes.ts 0.4.8` renders the summaries and the full changelog (116 lines). - `bun run check fast`: generated types, typecheck, build and 2800+ unit tests pass. ## Release After this merges and its CI on `main` passes: push `remote-v27`, wait for its release, then run the Release workflow with `0.4.8`. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
devswha
added a commit
that referenced
this pull request
Oct 12, 2026
…wsers (#854) ## Why From 0.4.7 mobile testing: a star pinned on the PC did not show on the phone, and settings changed on one device did not reach the other — both lived only in each browser's `localStorage`. The user chose to sync **pins + settings that do not depend on the device**, keeping per-device ones local. ## Design - **Scope, build-checked.** `SETTING_SCOPE` in `src/lib/settings.ts` marks every setting `shared` or `device` (`satisfies Record<keyof Settings, …>`, so a new setting must be classified). `shared/preferences.ts` lists the shared names; a unit test keeps the two equal. - shared: theme, palette, language, sidebarRows, agentOrder, agentCards, agentPins, autoSendQueued, showThinking, quickReplies, showQuickReplies, showSuggestionChip, showUsage, usageCount, usagePace, usageGlance, usageOrder, usageHidden, highlightCode - device: terminal*, keyBar*, shortcutOverrides, density, chat font/width, enterSends, keepScreenOn, alert*, voice*, paneClipboard, releasePaneAway, narrowPaneFont, quietOpenedDone, **defaultView** (phone chat vs desktop terminal) - Judgment calls for review: `language` (shared; `system` still resolves per browser), `defaultView` (device). - **Server** (`server/preferences.ts`): one document in `stateDir/preferences.json` (0600, written whole via temp+rename) `{ revision, settings, pins }`. `GET/PUT /api/preferences` (not under `/api/machines`, never forwarded to a bridge). A PUT carries only the changed shared settings, laid over what is held (last write wins per setting), and `pins` only when they changed; unknown names are dropped, ≤500 pins, ≤64 KB. Watch-role devices are refused by the existing read-only gate. Each write is pushed as `{ type: "preferences" }` on `/api/machines/events`. - **Client** (`src/lib/preferencesSync.ts`, used by `App` after the access gate): - load: a server with a document is applied (only the keys it holds); an empty server is never written on load; - change: debounced 600 ms, sends only what changed since the last match; - event: ignored at or below the last seen revision (own echo), or while a local change is unsent (it goes out next and wins); - 403 (watch device) → stop sending, keep receiving; 404 (older server) → sync off. - Pins moved to a small store in `sidebarPins.ts` (`useSyncExternalStore`), localStorage kept as cache. - The `?read=` file reader (#849) does not run any of this. ## Tests - Unit: `server/preferences.test.ts` (empty start, key stripping, merge, pins kept when omitted, revision, persistence, damaged file, 400/405/413), `preferencesSync.test.ts` (diff, apply), `settings.test.ts` (scope ↔ shared list). - Contract: `device-access.contract.test.ts` — a watch device GETs 200, PUTs 403. - Browser: new `preferences-sync-regression.ts` (two browsers, one server): no PUT on load; A's theme change reaches open B live and the PUT holds only `theme`; A's terminal font is never sent and B keeps its own; pins written elsewhere reach an open page; a later page takes the shared theme while keeping its own terminal font and an unchanged shared setting. Registered in `ci-browser.sh` (39 rows). - `bun run check fast`, integration lane (447 pass), full browser lane — all pass except `narrow-pane-demo-regression`, which fails on `main` on this machine too (scripts after it were run individually and pass). ## Notes - Interacts with #852 (pins stay in cards) in `AgentSidebar.tsx` — small textual conflict expected; whichever lands second needs a rebase. - Feature + new route: per the repo's review practice this one should get the adversarial review before merge. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Maintainer commit 08e6c8b: one reconcile path for every document, held documents during an in-flight save, the document sent when the event stream opens, pins absent until first shared (first-share union, then last write wins), prune at pin time, server commits after the disk write, merged document under 64 KB. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
From mobile/desktop testing of 0.4.7: Open in a new tab on a markdown file (#823) opened a second full copy of the app (sidebar, panes, chat, its own PC connections) with the file viewer as a modal over it. Closing the viewer left the tab as just another app window.
Change
src/lib/fileReader.ts:readerHref(machine, path)→?read=<path>&machine=<id>,readerFromSearch, andresolveFromDocument(a link resolved from the document's folder).src/main.tsx: a?read=address renders<FileReader>instead of<App>(still insideSettingsProvider, so theme/palette/language apply). Auth is the same cookie the app uses.FileReader:MachineContextfrom the address,FileViewerinpagemode,document.title= file name; links to other files push a new?read=entry and Back returns (popstate).FileViewerpageprop: a<main>instead of the modal; no focus trap, swipe-down, Escape or close button; header keeps name, size, path, Open raw file and Download (no "Open in a new tab" — it is the tab). The modal's "Open in a new tab" for markdown now points atreaderHref.?file=links (deep links, the address while the in-app viewer is open) are unchanged: they still open the app with the viewer.Tests
fileReader.test.ts(address round trip,?file=is not a reader address, relative/absolute/~/..resolution).file-viewer-regression: the new tab is a.file-readerwith aread=address, no sidebar/terminal/modal, no close or new-tab control, the file name as title; raw/download/reload as before; a relative link in the document opensother.mdin the reader and Back returns. PC ownership: the reader link from a remote-fixture file reads only through/api/machines/remote-fixture/fs/, and a reader address for a PC not set up here never reads/api/fs/.bun run check fastpasses. Screenshots at 390 and 1440, dark and light, checked.🤖 Generated with Claude Code