Repository navigation
feat(layout): arrange multiple pane views with docking presets - #657
Closed
od-studio-webagency wants to merge 2 commits into
Closed
od-studio-webagency wants to merge 2 commits into
od-studio-webagency wants to merge 2 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
Owner
|
Thanks for this, and for testing the PC-switch lifecycle across two PCs with the same pane ID. Closing the PR, for two reasons:
I'm keeping #641 open for browser docking only, so the scope can be agreed there before any code. If it's agreed, a fresh PR on current |
This was referenced Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Closes #641
Validation
생성 타입·타입·빌드 검사와 전체 단위 2048 통과·33 생략·0 실패. 실제 소유한 Herdr pane의 HTTP split/focus/resize/zoom 계약 통과. 실제 클라이언트의 가상 demo에서 native 조작, 방향별 드래그, 여섯 프리셋, DOM/badge 유지, pending 미재전송, zoom/mobile의 숨겨진 모드 보존, 같은 pane ID를 쓰는 원격 PC 구분과 포커스 복귀를 검증했습니다. 실제 SSH 연결·Safari touch는 검증하지 않았습니다.
모든 검증은 별도 작업 공간과 소유한 테스트/demo 환경에서 수행했습니다. 사용자의 실행 중 앱·terminal은 변경하지 않았습니다.
공개 전 검토에서 native 분할 화면의 PC 전환 수명주기 결함을 찾아 수정했습니다. 같은 pane ID를 가진 두 PC 사이에서 기존 소켓 종료, 새 PC attach, 입력 미재전송 및 명시적 Send의 정확한 원격 목적지를 검사합니다. 수정 전 원격 attach 대기 실패를 재현했고, 수정 후 타입·빌드 및 전체 layout 브라우저 회귀가 통과했습니다.
화면 증거
개인 대화나 사용자 세션이 아닌, 소유한 테스트/demo 환경의 가상 데이터로 촬영했습니다.