Repository navigation
fix: clipboard from a pane on by default, and patch-note style release notes - #598
Merged
Merged
Conversation
…cords vim, tmux and Claude Code copy through OSC 52; with the switch off since #570, copying from them silently did nothing. The switch stays in Settings -> Terminal. Settings are saved as one whole record, so 0.4.1 wrote terminalOsc52: false with any change at all. The choice now lives under a new key, paneClipboard, and the old key is ignored: a 0.4.1 record loads as on, and an off chosen from now on is stored under the new key and stays off.
The release body was the whole CHANGELOG section: 181 lines for v0.4.1. It now opens with the English lists from release-summaries.json under New features, Improvements and Bug fixes (an empty list left out), as an install shows them, and folds the full section under <details>. Every existing validation stays.
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (12)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
…notes A line break or a raw < in release-summaries.json could turn a line into markup or hide the Full changelog fold behind an HTML comment (Codex review). The gate now refuses a line with a break in any language, and the English lines escape <.
devswha
commented
Oct 8, 2026
devswha
left a comment
Owner
Author
There was a problem hiding this comment.
Independent review of 1439d97 (lead session; lane fix-notes wrote d0d0b75, 99047e6 and 1439d97).
Verdict: merge. The owner asked for both changes.
What I ran, in a scratch copy of 1439d97:
| Check | Result |
|---|---|
src/lib/settings.test.ts, scripts/release-notes.test.ts, server/release-notes.test.ts |
69 pass, 0 fail |
settings.test.ts with main's src/lib/settings.ts |
the 3 new "clipboard from a pane" cases fail (fresh default on; a 0.4.1 terminalOsc52: false record loads as on; a new off survives save/reload) |
Read:
- The new key
paneClipboardis the simplest correct migration: every 0.4.1 save wroteterminalOsc52: falsewhether or not it was chosen, so it cannot be trusted. The remaining edge (a tab still on the 0.4.1 bundle saving settings drops a new off until it is chosen again) fails toward copying working, which is the side the owner wants, and ends when that tab reloads. - The release notes are the English patch-note lists, then the full CHANGELOG section in
<details>with the blank lines GitHub needs. Every earlier validation stays; summary lines with a line break are refused and<is escaped, so no line can open a tag or hide the fold (Codex astra's verified finding, fixed in 1439d97). - The adversarial pass ran on gpt-6-astra (high). Its cross-tab note (no storage-event sync in SettingsProvider) predates this PR.
After merging I will regenerate the published v0.4.1 notes with this script.
This was referenced Oct 8, 2026
devswha
added a commit
that referenced
this pull request
Oct 8, 2026
## What
Anonymous install and update counts, announced and on by default
(opt-out):
- **When:** one event when an install first runs, one each time it runs
a new version, nothing in between. No event is sent before the app has
shown its one-time notice (a line under the header with **What is
sent**, **Turn off** and **Dismiss**), and the first one waits ten
minutes after it, so **Turn off** on the notice stops it. The notice is
recorded only once it was painted in a visible tab, and stays up until
the server confirms the switch is off.
- **What:** `event` (`install`/`update`), a random `install_id` made on
the PC, `version`, `previous_version`, `os`, `arch`, `install_method`
(`plugin`/`managed`/`source`). Nothing about terminals, agents, files or
accounts.
- **Off switch:** Settings → About → **Anonymous usage counts** shows
the next event exactly as it would be sent and turns it off.
`HERDR_WEB_TELEMETRY=0`, `DO_NOT_TRACK=1`, `CI` and the test
environments block it whatever the switch says.
- **Where it does nothing:** only the real entrypoint
(`server/index.ts`) passes a `Telemetry`, so `createServer` in tests,
remote-PC bridges and the demo answer `/api/telemetry` with 404 and the
app shows neither the notice nor the switch.
- **Receiver:** `telemetry/` is a Cloudflare Worker over one D1 table.
It never reads the sender's address or any header but the content type,
stores the day rather than the time, keeps each (install, event,
version) once, and has Workers Logs off. Deploy steps and the queries to
read the counts are in `telemetry/README.md`.
A failed send is logged once and tried again at the next start; it never
loops. Turning the switch off aborts a send in flight, the state file is
re-read before each decision (two servers on one state directory agree),
and a state directory that cannot be written leaves the app running with
telemetry silent.
## Contract
- `GET /api/telemetry` → `TelemetryStatus`; `POST /api/telemetry` `{
enabled?, notice_seen?: true }` with `x-herdr-update: 1` and same-origin
(`shared/telemetry.ts`, catalogued in `shared/protocol.ts`).
- `site/demo/transport.ts` answers 404 like a server without telemetry.
- `telemetry/` is added to `tsconfig.json` and to the unit-test glob in
`scripts/ci-tests.ts`.
## Before merging / releasing
- The lead deploys the Worker right after the merge (the D1 database
exists and its id is in `telemetry/wrangler.toml`; the account's
workers.dev subdomain is `devswha`, so `TELEMETRY_URL` in
`server/telemetry.ts` is right). Until then every send fails quietly:
one log line per start, retried at the next start.
## Verification
- `bun run test:unit`: 1790 pass, 0 fail (before rebasing onto v0.4.1);
after the rebase `bun run typecheck` and the telemetry, Worker and i18n
tests pass.
- `bun run build` passes.
- New tests: `server/telemetry.test.ts` (no send before the notice,
install once, update from the last reported version, switch, environment
blocks, retry after a refused send, route validation),
`telemetry/worker.test.ts` (stored fields, no address, refusals), and a
`telemetry API` block in `server/api.contract.test.ts` (404 without
telemetry, notice and switch through HTTP, token gate). The contract
block was not run locally; CI runs it.
- Browser check against a real server and a stand-in receiver
(Chromium): the notice shows on first open and the install event arrives
once; **What is sent** opens Settings → About; the switch turns sending
off on the server; after a reload the notice is not shown again; the
notice wraps cleanly at 390px in Korean.
## Review pass (merge lane)
- Merged `main` (v0.4.1, #598, #524); the changelog entry sits under `##
[Unreleased]`.
- Codex `gpt-6-astra` adversarial pass: six findings verified and fixed
in c74606b and 2f8a0bc, each with a test that fails without the fix
(`server/telemetry.test.ts`, `telemetry/worker.test.ts`); the rest are
listed in a comment below.
- `bun run check fast`: 1837 pass, 0 fail.
`server/api.contract.test.ts`: 96 pass. `scripts/update-browser-qa.ts`:
4 PASS.
- Browser check (Chromium, a real server and a stand-in receiver, 4 s
grace): the notice shows, nothing is sent until the grace passed and
then one install event arrives; a failed **Turn off** keeps the notice
with "Could not turn it off. Try again.", the retry closes it, the
switch is off on the server and nothing is sent after the grace; the
failure line fits at 390px.
Merged
devswha
added a commit
that referenced
this pull request
Oct 9, 2026
Release v0.4.2 from `main` at cc9701c. Stop before merge: the maintainer merges and runs the release. ## What's in it - Version 0.4.2 in `package.json` and `herdr-plugin.toml`. - CHANGELOG: `## [Unreleased]` cut into `## [0.4.2] - 2026-10-09`, compare links updated, the two #598 entries given their PR link. Outside contributors are credited as GitHub lists them as authors. - `release-summaries.json`: 0.4.2 patch notes in en/ko/ja/zh (new 5, improved 5, fixed 4). - `REMOTE_BUNDLE_VERSION` raised to `"22"`: the remote-PC bundle ships `server/`, `shared/` and `dist/` (`scripts/build-remote-bundle.ts`), and all three changed since remote-v21 (#543, #438, #599, #600, #601, #605 and others). A `remote-v22` tag is needed on the merge commit before the release. ## PRs since v0.4.1 #598, #524, #599, #603, #600, #601, #605, #438, #610, #607, #543 ## Whole-release review Codex astra (gpt-6-astra) over `v0.4.1..cc9701c`, looking for cross-PR problems: **no release blocker**. One Medium, verified by reading the code and left as a follow-up: in an OpenCode chat, "Show the whole output" fetched while a tool is still running can keep the older text if the tool later rewrites its output, because the output reference carries no revision. It affects only what is displayed until the row remounts; the fix needs a new protocol field, so it is out of scope for a release PR. ## Checks - `bun run check fast`: green locally (1928 pass, 6 skip, 0 fail; typecheck, build, generated types). - `server/release-notes.test.ts` and `scripts/release-notes.test.ts`: 27 pass; `bun scripts/release-notes.ts 0.4.2` renders the notes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes the owner asked for, one commit each.
1. Clipboard from a pane (OSC 52) is on by default
#570 turned Settings → Terminal → Clipboard from a pane off by default, so copying from vim, tmux and Claude Code silently did nothing. It is on again; the switch stays for anyone running output they do not trust.
Migration: a new storage key. Settings are saved as one whole record, so any 0.4.1 install whose user changed any setting has
terminalOsc52: falsestored without choosing it. The choice now lives underpaneClipboard(defaulttrue) andterminalOsc52is ignored and dropped bysanitizeSettings, which already discards unknown keys. That is the simplest correct option:falsecannot be told apart from a real choice, so it is not trusted);paneClipboardand stays off across saves and reloads;Known edge: a tab still running the 0.4.1 bundle that saves settings writes its own record, which has no
paneClipboard, so a new "off" would read as on again until it is re-chosen. Tabs pick up the new bundle on reload, and settings already have no cross-tab sync (each tab saves its in-memory record), so this is no worse than any other setting.Tests (
src/lib/settings.test.ts, "clipboard from a pane"): fresh default on; a 0.4.1 record withterminalOsc52: falseloads as on; an off chosen after the change survives a save, a reload and an unrelated change. A mutation that falls back to the old key fails the second case.Also: the setting's description and code comments say what is true now, ko/ja/zh entries are updated, and there is a CHANGELOG line under Unreleased → Changed. No doc in
docs/,DESIGN.md,INSTALL.mdorREADME.mdmentions the default.2. Patch-note style GitHub release notes
scripts/release-notes.tsprinted the whole CHANGELOG section (181 lines for v0.4.1). It now prints the English lists fromrelease-summaries.json(### New features,### Improvements,### Bug fixes, a list with no lines left out), then the full section inside<details><summary>Full changelog</summary>with blank lines around it so GitHub renders the markdown. Lines come throughreadSummary, so they are trimmed and capped exactly as an install shows them. Every validation is unchanged (version format, the three version sources, exactly one heading, nonempty notes, all four languages).scripts/release-notes.test.tspins the shape, the order and an empty list left out.docs/development.md→ Releasing andscripts/AGENTS.mddescribe the new body.The published v0.4.1 release is not touched here; the lead regenerates it after the merge.
v0.4.1 rendered with this script (
bun scripts/release-notes.ts 0.4.1)New features
Improvements
Bug fixes
Full changelog
Added
/effortsent from a Claude Code chat opens a card with the effort levels, low to max, so thelevel no longer has to be set in the terminal. A pick applies to this session only, as a pick
from the
/modelcard does, and leaves the default for new sessions alone./effortis also inthe chat's command list now.
(#594,
#523 by @suho-han)
pane can no longer put text on your clipboard unless you turn it on. Programs that copy this way
(vim, tmux, Claude Code) copy again once it is on.
(#570 by @radicor)
Portal v2.6.1 or later, behind a long random token
and with a visitor's
Tailscale-User-Loginheader dropped.(#229 by @rabbitson87)
list and orders the rest by their latest state change, as herdr's agents panel keeps the latest
work in view: the agent you just sent a message to stays on top while it runs and after it
finishes, and a new one starts there. herdr's own order and the workspace rows are unchanged.
Workspaces (herdr's order) remains the default.
(#529 by @phirschybar)
opened in the web UI loses its dot and reads as ready, as viewing it in herdr would make it.
herdr's DONE otherwise stands until herdr itself shows the pane. It is remembered per PC in
this browser. (#529 by @phirschybar)
Changed
is typed into the sign-in form or sent with a request. Each visitor behind
tailscale servehastheir own count, and a browser holding an old token never stops you signing in with the new one.
(#570 by @radicor)
math, agent marks — cannot run script in the app.
(#570 by @radicor)
(#570 by @radicor)
Fixed
startup selectors shown before the pane reports that it is waiting. Answers move to the selected
row and recheck the menu before confirming.
(#593)
prompt or collapsed question queue in scrollback cannot send input into the current program.
(#566)
JavaScript number, so the owner was not recognised and the owner's own devices had to pair. Two
logins with neighbouring ids are also no longer taken for one.
(#572)
~/.claude-*directory as itsCLAUDE_CONFIG_DIRshows its chat. Before, the pane fell back to~/.claude, so the chat saidConversation unavailable and only the terminal worked. Windows does not let the server read
another process's environment, so the store is the one among the server's own
CLAUDE_CONFIG_DIR,~/.claudeand the~/.claude-*directories beside it that holds theClaude process's own record, checked against the time the process started. A directory
elsewhere is not looked in. Claude Code processes reported as
claude.exearerecognized too.
(#563 by @David-Sousa-Web)
\(or underscores that never close, as an agent prints in a log or aminified file, no longer freezes the chat: a megabyte of them took a minute or more to read, and
now takes milliseconds. What every message shows is unchanged.
(#574)
was still being sent no longer reaches the pane once you have left it, or left it and opened it
again, before the text's turn came.
(#576)
startkeeps the app on its port when the app's own server holds it but cannotreach herdr. It used to move the app to another port beside the running one and blame another
program; now it says that the app runs there without herdr and exits, and the app answers
again on its port once herdr is back.
(#577)
\\?\prefix, asit does for a canonical Windows path (
\\?\D:\workforD:\work). Before, the chat saidConversation unavailable: the session's file seemed to lie outside Codex's store, and none of
the threads matched the pane's directory as herdr reports it.
(#582 by @David-Sousa-Web)
/goalthat ClaudeCode refuses says why in the chat instead of only in the terminal.
/goalis also among thecommands the message box suggests.
(#583)
first, preserving the preview and its history entry until the file itself is closed.
(#568)
stay with text input, and arrow navigation keeps the selected result visible.
(#567)
scrollbar no longer covers text at fractional zoom.
(#522 by @suho-han)
open, is no longer typed into the pane: you send it again from the pane you opened.
(#588)
longer stalls the server while the chat reads it. Its answer also drops a link cut off before
its end and a stray
Bafter a charset switch, and an answer with both output and errorsshows both.
(#588)
taking the keyboard unseen beneath them.
(#588)
startno longer takes another program on the app's port for the app becauseits answer says
ok: it treats it as any other program there, moving the app to a free port,or saying the port is taken when
PORTis set.(#588)
and the herdr socket location; it names a short id you can quote in a bug report instead.
(#570 by @radicor)
Tab inside them and give the focus back to whatever opened them.
(#570 by @radicor)
the pane together.
(#570 by @radicor)
own headings and look the same as before.
(#570 by @radicor)
(#570 by @radicor)
date in your language) and a remote PC's state word in the sidebar are translated like the rest of
the UI.
(#570 by @radicor)
(#570 by @radicor)
(#570 by @radicor)
(#570 by @radicor)
sees that send on its way and holds back. Two tabs that press Send at nearly the same moment can still
both send it.
(#570 by @radicor)
viewport, so the pane picker of a tab with many panes keeps every entry reachable with the pointer
as well as the keyboard. Before, items below the fold were rendered but unreachable.
(#570 by @radicor)
popover instead of keeping the form it opened with.
(#570 by @radicor)
so narrowing it no longer brings back a drawer and its scrim unasked.
(#570 by @radicor)
every other dialog, and keep clear of the on-screen keyboard. Before, the one native dialog stayed
a centred card on a phone.
(#570 by @radicor)
red one, as revoking a device already was.
(#570 by @radicor)
click no longer sends two overlapping requests.
(#570 by @radicor)
longer makes you write the name again.
(#570 by @radicor)
(#570 by @radicor)
past a byte budget, not only past sixteen of them.
(#570 by @radicor)
(#570 by @radicor)
design tokens now, and the pairing code follows the compact density setting.
(#570 by @radicor)
restarting it again, while a bridge from a newer app is left running instead of downgraded.
A PC that waits on such a conflict says so in the sidebar and under the header, with a
Reconnect button, instead of asking for setup approval.
(#519 by @suho-han)
X-Forwarded-Foraddressthat itself says " via " now counts against the limit every visitor through that proxy shares,
like any other wrong token. Before, each such try started a fresh count.
(#592)
never sent on where a push service redirects it, so an alert can never be posted to a service
running on this PC. (#592)
and Escape closes the dialog alone, leaving the preview beneath it open.
(#592)
Checks
bun run check fast: ok (1817 pass, 6 platform skips, 0 fail).terminal-copy-regression.tscovers drag and Ctrl+C copy), so none was run for it.Codex review (gpt-6-astra, read-only)
"…\n\n<!--"could hide the whole changelog fold. The gate now refuses a summary line with a line break in any language, and the English lines escape<. A test covers both and fails without the fix.paneClipboard, so a new "off" reads as on until it is chosen again. A versioned storage key would stop that, but then every setting changed in such a tab would be lost instead. It lasts only until that tab reloads, and every setting added before this one had the same gap.