Repository navigation
Read wire facts from dau-core and drop the undriven status bits - #93
Merged
Merged
Conversation
Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
timkpaine
marked this pull request as ready for review
October 23, 2026 17:45
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #93 +/- ##
==========================================
- Coverage 90.05% 89.95% -0.10%
==========================================
Files 41 41
Lines 4132 4093 -39
Branches 376 376
==========================================
- Hits 3721 3682 -39
Misses 305 305
Partials 106 106 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes V3 of the flip review: device semantics the driver restated now come from dau-core (dau-core#214).
CAPABILITY_WORDS_REGISTER_MAP_VERSION,JOB_CAPACITY_REGISTER_MAP_VERSION) are imported fromdau_core.registers.dau_core.stream.LOGICAL_TYPE_BYTE_WIDTHS.struct_format/numpy_dtype_fieldscome fromdau_core.records, where dau-core's suite checks them against the tiles' registry entries and goldens.pack_keyed_rowsanddecode_group_recordsnow read their formats from the layouts instead of literal struct strings, and the bar-layout test moves to dau-core.DeviceStatusdropslink_ready,mig_ready,operator_readyandreset_activeand their bit constants. No shell assigns STATUS bits (the identity block'sSTATUSparameter defaults to 0 and nothing sets it), so the properties decoded a word that is always zero; only a test read them.raw_statusandlast_errorstay.DMA_ALIGN_BYTESstays: it is the transfer format's grid, used by packing helpers that have no device in hand.Draft until dau-core#214 merges and dau-core 0.2.0 is released: CI installs dau-core from GitHub main, which does not have
dau_core.recordsyet, and thegit+pin then becomesdau-core>=0.2. Locally, against #214's branch, the suite passes (216 passed, 2 skipped) andmake lintandmake checksare clean. dau and dau-polars import the bar sizes and layouts from this package and move todau_core.recordsin their own PRs.