Skip to content

Read wire facts from dau-core and drop the undriven status bits - #93

Merged
timkpaine merged 1 commit into
mainfrom
tkp/core-wire-facts
Oct 23, 2026
Merged

timkpaine merged 1 commit into
mainfrom
tkp/core-wire-facts

Conversation

@timkpaine

Copy link
Copy Markdown
Member

Closes V3 of the flip review: device semantics the driver restated now come from dau-core (dau-core#214).

  • The register-map version gates (CAPABILITY_WORDS_REGISTER_MAP_VERSION, JOB_CAPACITY_REGISTER_MAP_VERSION) are imported from dau_core.registers.
  • The stream codec's per-type wire widths are dau_core.stream.LOGICAL_TYPE_BYTE_WIDTHS.
  • The keyed-row, group-record, bar-row and bar-record layouts, their sizes, and struct_format / numpy_dtype_fields come from dau_core.records, where dau-core's suite checks them against the tiles' registry entries and goldens. pack_keyed_rows and decode_group_records now read their formats from the layouts instead of literal struct strings, and the bar-layout test moves to dau-core.
  • DeviceStatus drops link_ready, mig_ready, operator_ready and reset_active and their bit constants. No shell assigns STATUS bits (the identity block's STATUS parameter defaults to 0 and nothing sets it), so the properties decoded a word that is always zero; only a test read them. raw_status and last_error stay.
  • The wiki pages and the OHLCV example follow; the tutorial's blocks run in order and print what the page shows.

DMA_ALIGN_BYTES stays: it is the transfer format's grid, used by packing helpers that have no device in hand.

Draft until dau-core#214 merges and dau-core 0.2.0 is released: CI installs dau-core from GitHub main, which does not have dau_core.records yet, and the git+ pin then becomes dau-core>=0.2. Locally, against #214's branch, the suite passes (216 passed, 2 skipped) and make lint and make checks are clean. dau and dau-polars import the bar sizes and layouts from this package and move to dau_core.records in their own PRs.

Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
@timkpaine
timkpaine marked this pull request as ready for review October 23, 2026 17:45
@github-actions

Copy link
Copy Markdown

Test Results

218 tests   - 1   216 ✅  - 1   4s ⏱️ -2s
  1 suites ±0     2 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit bf28afb. ± Comparison against base commit 459374b.

This pull request removes 1 test.
dau_driver.tests.test_pipeline_execution ‑ test_the_bar_layout_has_one_declaration

@codecov

codecov Bot commented Oct 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 89.95%. Comparing base (459374b) to head (bf28afb).

Files with missing lines Patch % Lines
dau_driver/stream_codec.py 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #93      +/-   ##
==========================================
- Coverage   90.05%   89.95%   -0.10%     
==========================================
  Files          41       41              
  Lines        4132     4093      -39     
  Branches      376      376              
==========================================
- Hits         3721     3682      -39     
  Misses        305      305              
  Partials      106      106              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@timkpaine
timkpaine merged commit 8c3decf into main Oct 23, 2026
9 of 15 checks passed
@timkpaine
timkpaine deleted the tkp/core-wire-facts branch October 23, 2026 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant