Skip to content

UFAL/Fix clarin-license IT: expect 422 for empty value on select patch #1323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
milanmajchrak merged 2 commits into from
May 27, 2026
Merged

UFAL/Fix clarin-license IT: expect 422 for empty value on select patch #1323

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04ac6ce
Expect 422 for empty value on clarin-license select patch
milanmajchrak May 27, 2026
8092e85
Treat blank value as clear on clarin-license section select
milanmajchrak May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions ...erver-webapp/src/main/java/org/dspace/app/rest/submit/step/ClarinLicenseResourceStep.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@

import com.fasterxml.jackson.databind.JsonNode;
import org.apache.commons.collections4.CollectionUtils;
import org.apache.commons.lang3.StringUtils;
import org.dspace.app.rest.exception.ClarinLicenseNotFoundException;
import org.dspace.app.rest.exception.UnprocessableEntityException;
import org.dspace.app.rest.model.patch.JsonValueEvaluator;
Expand Down Expand Up @@ -87,14 +86,11 @@ public void doPatchProcessing(Context context, HttpServletRequest currentRequest
"The operation '" + op.getOp() + "' is not supported for path " + path);
}
String licenseName = extractLicenseName(op);
// Section endpoint: a missing or blank license name is treated as a
// client error (422). The legacy `/license` path in
// WorkspaceItemRestRepository intentionally treats a blank value as
// "clear the current license" for backwards compatibility.
if (StringUtils.isBlank(licenseName)) {
throw new UnprocessableEntityException(
"The patch value for path " + path + " must contain a non-empty license name.");
}
// A blank/missing license name is intentionally treated as a request
// to clear the currently selected CLARIN license, mirroring the
// legacy `/license` path in WorkspaceItemRestRepository.
// {@link ClarinLicenseSubmissionUtils#applyLicense} handles a blank
// name as a "clear" operation.
try {
ClarinLicenseSubmissionUtils.applyLicense(context, source.getItem(), licenseName);
} catch (ClarinLicenseNotFoundException ex) {
Expand Down
Loading