UFAL/Fix clarin-license IT: expect 422 for empty value on select patch#1323
Merged
Conversation
milanmajchrak
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Post-merge follow-up to #1319.
The integration test
patchSelectWithEmptyValueClearsLicensefailed ondtq-devbecause it expected the section endpoint/sections/clarin-license/selectto treat an empty value as "clear the license" (200 OK), while the merged implementation rejects a blank license name with 422 Unprocessable Entity. The legacy/licensepath keeps its blank-as-clear semantics; the new section endpoint requires a non-empty license name.This PR aligns the test with the implemented contract: the test now patches with an empty value and asserts 422, plus verifies the previously selected license stays attached to the item and bitstream.