Skip to content

fix(python-setup): fix red main — align two lagging tests with the array showError signature #2165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rugpanov merged 1 commit into from
Sep 2, 2026
Merged

fix(python-setup): fix red main — align two lagging tests with the array showError signature #2165

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions packages/databricks-vscode/src/python-setup/controllers/PythonSetupEnvironmentSetup.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -576,7 +576,7 @@ describe("PythonSetupEnvironmentSetup.setup", () => {
it("prompts re-login (no report) when the CLI aborts telling the user to re-authenticate", async () => {
const shownErrors: {
message: string;
action?: PythonSetupErrorAction;
actions?: PythonSetupErrorAction[];
}[] = [];
let reauthPrompts = 0;
const telemetry = makeTelemetryRecorder();
Expand All @@ -594,8 +594,8 @@ describe("PythonSetupEnvironmentSetup.setup", () => {
showReauthPrompt: async () => {
reauthPrompts++;
},
showError: async (message, _detail, action) => {
shownErrors.push({message, action});
showError: async (message, _detail, actions) => {
shownErrors.push({message, actions});
},
})
);
Expand All @@ -613,7 +613,7 @@ describe("PythonSetupEnvironmentSetup.setup", () => {
});

it("reports a spawn/parse defect (not re-login) when the abort has no reauth signal", async () => {
const shown: {action?: PythonSetupErrorAction}[] = [];
const shown: {actions?: PythonSetupErrorAction[]}[] = [];
let reauthPrompts = 0;
const telemetry = makeTelemetryRecorder();
const setup = new PythonSetupEnvironmentSetup(
Expand All @@ -625,16 +625,16 @@ describe("PythonSetupEnvironmentSetup.setup", () => {
showReauthPrompt: async () => {
reauthPrompts++;
},
showError: async (_m, _detail, action) => {
shown.push({action});
showError: async (_m, _detail, actions) => {
shown.push({actions});
},
})
);

await setup.setup();

expect(reauthPrompts).to.equal(0);
expect(shown[0].action?.label).to.equal("Report this problem");
expect(shown[0].actions?.[0].label).to.equal("Report this problem");
expect(telemetry.results[0]).to.include({
outcome: "not_started",
reportOffered: true,
Expand Down
Loading