fix(python-setup): fix red main — align two lagging tests with the array showError signature - #2165
Merged
Merged
Conversation
…ignature *Why* main is red: VSCode Extensions CI and the nightly release both fail at the packaging typecheck (`tsc --build --force`) with TS2322 in PythonSetupEnvironmentSetup.test.ts. #2163 changed showError's third parameter to `PythonSetupErrorAction[]`, and every sibling test was migrated to the plural `actions` form, but two tests still typed it as a single `PythonSetupErrorAction`. *What* Adopt the array shape the rest of the file already uses in the two lagging tests: the `shownErrors`/`shown` local field types, the `showError` callback parameter names, and the one assertion now reads `actions?.[0].label`. No product code changes; behaviour is unchanged. *Verification* `yarn build` compiles clean (exit 0, no TS errors); the 53 PythonSetupEnvironmentSetup unit tests pass in the VS Code test host, including both previously-failing tests. Co-authored-by: Isaac <no-reply@databricks.com>
Contributor
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
Contributor
Author
|
🤖 Integration tests ✅ all 41 test jobs passed for |
misha-db
approved these changes
Sep 2, 2026
rugpanov
marked this pull request as ready for review
September 2, 2026 08:20
Merged
rugpanov
added a commit
that referenced
this pull request
Sep 3, 2026
Release **v2.16.0** of the Databricks VS Code extension. Tracking: DECO-28403 ## packages/databricks-vscode - Add a manual mode to opt out of automated Python environment (uv) setup (#2158) - Offer a one-click "Install uv" action when uv is missing (#2162) - Prompt re-login on setup-local session expiry instead of a hard error (#2163) - Normalize notebook cell source before wrapping jobs, fixing "Run as Databricks Job" when a cell's source is a JSON string (#2143) — reported in #2142 - Update Databricks CLI to v1.14.1 (#2160) — see the [CLI release notes](https://github.com/databricks/cli/releases) for changes _Changelog curated: internal refactor (#2148) and CI/test-only changes (#2165, #2141) omitted; auto-close issue refs stripped._ --------- Co-authored-by: releasebot <noreply@github.com> Co-authored-by: @rugpanov <gripanov@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
mainis red. Both VSCode Extensions CI and Publish nightly release fail at the packaging typecheck (tsc --build --force) at tip commit 3ebc920 (#2163) with:#2163 changed
showError's third parameter from a singlePythonSetupErrorActiontoPythonSetupErrorAction[]. Every sibling test in the file was migrated to the pluralactions/actions?.[0]form, but two tests were missed and still typed the parameter as a singlePythonSetupErrorAction. It's a test-only, compile-time type mismatch — no product code is involved.What
In the two lagging tests, adopt the exact array shape the rest of the file already uses:
shownErrorsfieldaction?: PythonSetupErrorAction→actions?: PythonSetupErrorAction[]; callback paramaction→actions.shownfield likewise; callback paramaction→actions; assertionshown[0].action?.label→shown[0].actions?.[0].label.No product behaviour changes.
Verification
yarn build(tsc --build --force) compiles clean — exit 0, no TS errors.PythonSetupEnvironmentSetupunit tests pass in the VS Code test host, including both previously-failing tests.This pull request and its description were written by Isaac.