Skip to content

Make file count validation to not do remote path checks #6507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andrewnester wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make file count validation to not do remote path checks #6507

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions bundle/deploy/files/sync.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,15 @@ import (
"github.com/databricks/cli/libs/sync"
)

// GetSync returns a new sync instance for the given bundle.
// The sync instance will be in no validate remote path mode because it's only used to validate files to sync.
// It does not check or create the remote path.
func GetSync(ctx context.Context, b *bundle.Bundle) (*sync.Sync, error) {
opts, err := GetSyncOptions(ctx, b)
if err != nil {
return nil, fmt.Errorf("cannot get sync options: %w", err)
}
opts.NoValidateRemotePath = true
return sync.New(ctx, *opts)
}

Expand Down
2 changes: 2 additions & 0 deletions libs/sync/sync.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@ type SyncOptions struct {
OutputHandler OutputHandler

DryRun bool

NoValidateRemotePath bool
}

type Sync struct {
Expand Down
Loading