Skip to content

Make file count validation to not do remote path checks - #6507

Open
andrewnester wants to merge 1 commit into
mainfrom
fix/sync-no-validate
Open

Make file count validation to not do remote path checks#6507
andrewnester wants to merge 1 commit into
mainfrom
fix/sync-no-validate

Conversation

@andrewnester

@andrewnester andrewnester commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Changes

Make file count validation to not do remote path checks

Why

files_to_validate check which is run on bundle validate and only used to count local files to be uploaded did a remote calls to check that remote paths are there even though it should not

Discovered in #6084 where the remote path is not known and existent until the deploy

Tests

Covered by existing acceptance tests

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Approval status: pending

/bundle/ - needs approval

Files: bundle/deploy/files/sync.go
Suggested: @pietern
Also eligible: @denik, @anton-107, @janniklasrose, @lennartkats-db, @shreyas-goenka

/libs/sync/ - needs approval

Files: libs/sync/sync.go
Suggested: @simonfaltum
Also eligible: @renaudhartert-db, @hectorcast-db, @parthban-db, @tanmay-db, @Divyansh-db, @tejaskochar-db, @mihaimitrea-db, @chrisst, @rauchy

Any maintainer (@anton-107, @denik, @pietern, @shreyas-goenka, @simonfaltum, @renaudhartert-db, @janniklasrose, @lennartkats-db, @rugpanov, @rclarey) can approve all areas.
See OWNERS for ownership rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant