Skip to content

jobs: do not try to delete duplicate XMP if it does not exist #22228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TurboGit merged 2 commits into from
Sep 10, 2026
+7 −0
Merged

jobs: do not try to delete duplicate XMP if it does not exist #22228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1bdb39
jobs: do not try to delete duplicate XMP if it does not exist
masterpiga Sep 10, 2026
482c287
Add release note entry for trashing error
masterpiga Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions RELEASE_NOTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,9 @@ changes (where available).

## Bug Fixes

- Fixed a trashing error dialog when deleting a virgin duplicate of an
image while sidecar creation is set to "after edit".

- Fixed color harmonizer's auto-detect harmony applying the hue
histogram of the previously viewed image after switching images in the
darkroom.
Expand Down
4 changes: 4 additions & 0 deletions src/control/jobs/control_jobs.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1369,6 +1369,10 @@ static _dt_delete_status_t delete_file_from_disk
{
_dt_delete_status_t delete_status = _DT_DELETE_STATUS_UNKNOWN;

// if the file does not exist on disk, it is already deleted
if(!g_file_test(filename, G_FILE_TEST_EXISTS))
return _DT_DELETE_STATUS_DELETED;

GFile *gfile = g_file_new_for_path(filename);
int send_to_trash = dt_conf_get_bool("send_to_trash");

Expand Down
Loading