jobs: do not try to delete duplicate XMP if it does not exist - #22228
Merged
Conversation
1 task
masterpiga
added
bugfix
|
I tested this and the trashing error is done. Thanks! |
TurboGit
reviewed
Sep 10, 2026
masterpiga
force-pushed
the
fix_22160
branch
from
September 10, 2026 18:05
f591801 to
482c287
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When deleting a duplicate image whose sidecar file does not exist on
disk (such as a virgin duplicate when XMP writing is set to "after
edit"), darktable still attempted to send the non-existent XMP file
to trash. On Windows,
dt_win_file_trash()failed withG_IO_ERROR_FAILEDrather than
G_IO_ERROR_NOT_FOUND, prompting the user with an errordialog.
Check for file existence before attempting to delete the duplicate's
sidecar, and guard
delete_file_from_disk()to treat absent files asalready deleted.
UNTESTED, as I do not have access to a windows machine.
Fixes #22160