Testing: Use native Testcontainers adapter by amotl · Pull Request #502 · crate/crash

amotl · 2026-06-18T15:41:58Z

About

Thanks to @surister and @florinutz, the upstream testcontainers package will include an adapter for CrateDB. With this patch, the test suite will start using it.

References

amotl · 2026-07-27T14:27:09Z

@florinutz: I think the patch is ready to go now.

florinutz · 2026-09-17T09:09:59Z

hey @amotl , thank you for the contribution, first, and sorry for the delayed response!

then, I see you drop the dependency on the toolkit here. My current plan is to have toolkit updated first, and only after this to proceed further with any new testcontainers-python work such as this here, or updating the examples

Let me get that released first, then it will unlock using the new testcontainers 4.15 (alongside toolkit and its testcontainer goodies) in the repos so we don't have to reimplement things such as you did here.

amotl · 2026-09-21T17:43:13Z

Hi, and thanks! Please proceed at your disposal.

florinutz

Hey, I have some comments which I'd like addressed in this PR before we merge. I can do them if you ✅ "Allow edits by maintainers", or you can do them yourself if you so desire.

Or ofc you can hit back on any point

florinutz · 2026-10-09T13:11:13Z

+                if "CRATEDB_VERSION" in os.environ:
+                    cratedb_version = os.environ["CRATEDB_VERSION"]
+                    if cratedb_version != "nightly" and Version(cratedb_version) < Version("6.2"):
+                        warnings.warn("CrateDB earlier than 6.2 does not support DROP SCHEMA ... CASCADE")


this is actually 6.3, not 6.2

florinutz · 2026-10-09T13:20:18Z

+            if schemas:
+                has_drop_schema_cascade = True
+                if "CRATEDB_VERSION" in os.environ:
+                    cratedb_version = os.environ["CRATEDB_VERSION"]


the constructor already gets crate_version, so we should use that

florinutz · 2026-10-09T13:51:25Z

        ],
        argcompletion=['argcomplete']
    ),
    python_requires='>=3.7',


testcontainers needs python 3.10+, so this file should reflect that. It should also be in CHANGES

florinutz · 2026-10-09T13:53:09Z


 isort --check --diff src/crate/ tests/ setup.py
 flake8 src/crate/crash
+export TESTCONTAINERS_RYUK_DISABLED=true


with Ryuk off, a failed setup leaves the crate container running. Do we actually need this?

florinutz · 2026-10-09T13:53:37Z


 The tests are run using the `unittest`_ module::

+    export TESTCONTAINERS_RYUK_DISABLED=true


if we don't need ryuk, let's remove it from here too

florinutz · 2026-10-09T13:54:33Z

    return Mock(name='fake_connect', side_effect=make_connection)
+
+
+def setup_logging(level=logging.INFO, verbose: bool = False):


verbose is not used

florinutz · 2026-10-09T13:55:15Z

+        """
+        Return a URL for CrateDB's HTTP endpoint.
+
+        Used to stay backward compatible with the downstream code.


which downstream code? 🤔

florinutz · 2026-10-09T13:59:42Z

-        python-version: ['3.7', '3.8', '3.9', '3.10', '3.11', '3.12', '3.13', '3.14']
-        cratedb-version: ['4.8.4', '5.9.2']
+        python-version: ['3.10', '3.11', '3.12', '3.13', '3.14']
+        cratedb-version: ['4.8.4', '5.10.16', '6.3.3']


6.4.6 is the current release; worth bumping here and in the macOS and Windows slots below

florinutz · 2026-10-09T14:00:54Z

+
+    def __init__(self, crate_version: str = "nightly", **kwargs) -> None:
+        self.cratedb: Optional[CrateDBContainer] = None
+        self.image: str = "crate/crate:{}".format(crate_version)


crate/crate release tags are amd64-only, so on an arm Mac this fails or runs emulated; crate/crate:nightly for nightly and the official crate:<version> for releases works on both

amotl · 2026-10-09T14:09:35Z

Hey, I have some comments which I'd like addressed in this PR before we merge. I can do them if you ✅ "Allow edits by maintainers", or you can do them yourself if you so desire.

Hi. I received such requests multiple times in the past, but I've never been able to find the "Allow edits by maintainers" toggle. Can you provide relevant guidance?

Or ofc you can hit back on any point.

Can you explain what ofc means?

florinutz · 2026-10-09T14:12:57Z

Allow edits by maintainers

I couldn't find it either when you asked it the other day 👀
Here, maybe? https://docs.github.com/en/pull-requests/how-tos/work-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

Can you explain what ofc means?

of course I can

amotl · 2026-10-09T14:19:41Z

Ah, thanks. Well, this option does not exist on this PR. ;[

In this case, feel free to close the PR and stage my commits into another one. 🙇

florinutz · 2026-10-09T14:29:23Z

ah, your fork is owned by the zerotired org. Seems gh shows "Allow edits from maintainers" only on pull requests from forks owned by a person

florinutz · 2026-10-09T17:01:26Z

Thank you @amotl ! continuing this in #518

amotl commented Jun 18, 2026

View reviewed changes

Comment thread setup.py Outdated

amotl mentioned this pull request Jun 18, 2026

Trim dependencies #485

Open

amotl force-pushed the testcontainers-native branch 2 times, most recently from f073808 to 8768c26 Compare June 18, 2026 15:59

amotl mentioned this pull request Jul 11, 2026

Tests: Add integration tests with CrateDB panodata/omniload#192

Draft

amotl added 2 commits July 27, 2026 00:29

CI: Use Python 3.14, CrateDB 5.10.16 and 6.3.3

521ea04

CI: Stop testing on Python 3.7 through 3.9

f4a1931

amotl force-pushed the testcontainers-native branch from 8768c26 to ee4f661 Compare July 26, 2026 22:30

github-advanced-security Bot found potential problems Jul 26, 2026

View reviewed changes

Comment thread tests/util.py Fixed

amotl force-pushed the testcontainers-native branch from ee4f661 to d834054 Compare July 26, 2026 22:32

Testing: Migrate to native testcontainers package

d834054

amotl requested a review from florinutz July 26, 2026 22:34

amotl marked this pull request as ready for review July 26, 2026 22:35

florinutz requested changes Oct 9, 2026

View reviewed changes

florinutz mentioned this pull request Oct 9, 2026

Testing: Use native Testcontainers adapter #518

Open

florinutz closed this Oct 9, 2026


		The tests are run using the `unittest`_ module::

		export TESTCONTAINERS_RYUK_DISABLED=true

		return Mock(name='fake_connect', side_effect=make_connection)


		def setup_logging(level=logging.INFO, verbose: bool = False):

Conversation

amotl commented Jun 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

About

References

Uh oh!

Uh oh!

Uh oh!

amotl commented Jul 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

florinutz commented Sep 17, 2026

Uh oh!

amotl commented Sep 21, 2026

Uh oh!

florinutz left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

amotl commented Oct 9, 2026

Uh oh!

florinutz commented Oct 9, 2026

Uh oh!

amotl commented Oct 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

florinutz commented Oct 9, 2026

Uh oh!

florinutz commented Oct 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

amotl commented Jun 18, 2026 •

edited

Loading

amotl commented Jul 27, 2026 •

edited

Loading

amotl commented Oct 9, 2026 •

edited

Loading