Skip to content

Tests depend on cratedb-toolkit, which depends on this package #157

Closed

Description

@florinutz

This package and cratedb-toolkit depend on each other. The test suite gets its crate container from the toolkit's test helper (cratedb_toolkit.testing.testcontainers.cratedb.CrateDBTestAdapter), so .[test] installs cratedb-toolkit[testing], while the toolkit's dynamodb, kinesis and mongodb extras require commons-codec.

The cycle costs this repository at test time. pip never has to resolve the loop, because cratedb-toolkit[testing] leaves those extras out, but .[test] installs the whole toolkit, with crash and the rest of its dependencies, for one container class, so a toolkit release that fails to install would break this CI with nothing here changed. A library the toolkit builds on should not run its tests on the toolkit.

The tests should start the container from testcontainers-python itself, which since version 4.15 ships a crate container class (testcontainers.community.cratedb.CrateDBContainer) that needs nothing beyond what this package already depends on, and keep the few SQL helpers they use (run_sql, refresh_table, count_records, table_exists, and the reset that drops tables between tests) in a small class under tests/. crate/crash#502 does the same for crash; the two do not wait on each other.

Settled when .[test] no longer installs cratedb-toolkit and CI is green.

Activity

  1. self-assigned this
    on Oct 9, 2026
  2. amotl commented on Oct 9, 2026

    @amotl
    Contributor

    Yes. Please use vanilla Testcontainers for Python going forward like the referenced patch is doing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions