Skip to content

feat(web): the provider step preselects no provider (CL-9506) #972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheGreatAxios merged 3 commits into from
Sep 30, 2026
Merged

feat(web): the provider step preselects no provider (CL-9506) #972

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a5af16a
feat(web): the provider step preselects no provider (CL-9506)
TheGreatAxios Sep 30, 2026
09fabae
style(web): format the provider step (CL-9506)
TheGreatAxios Sep 30, 2026
7e4dc39
Merge branch 'main' into cl-9506-provider-picker
TheGreatAxios Sep 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 18 additions & 11 deletions apps/web/src/onboarding/provider-connect-step.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,10 @@ export async function resolveExistingOffering(
const models = await getResolvedCatalog(tenantId, fetchImpl);
const offerings = models
.flatMap((model) =>
model.offerings.map((offering) => ({ ...offering, model: model.canonicalName })),
model.offerings.map((offering) => ({
...offering,
model: model.canonicalName,
})),
)
.sort((a, b) => a.priority - b.priority);
const defaultSourceOfferingId = offerings[0]?.offeringId;
Expand Down Expand Up @@ -173,15 +176,15 @@ export function ProviderConnectStep({
readonly onConnected: (offering: ExistingOffering) => void;
readonly onError: (message: string) => void;
}) {
const [selected, setSelected] = useState<string>(PROVIDER_OPTIONS[0]?.id ?? "anthropic");
const [selected, setSelected] = useState<string | null>(null);
const [apiKey, setApiKey] = useState("");
const [baseURL, setBaseURL] = useState("");
const [modelName, setModelName] = useState("");
const [submitting, setSubmitting] = useState(false);
const [loginId, setLoginId] = useState<string | null>(null);

const option =
PROVIDER_OPTIONS.find((candidate) => candidate.id === selected) ?? PROVIDER_OPTIONS[0];
// No provider is preselected: the person chooses.
const option = PROVIDER_OPTIONS.find((candidate) => candidate.id === selected);
const isLocal = option?.local === true;
const oauthProvider = option?.oauthProvider;

Expand All @@ -200,10 +203,11 @@ export function ProviderConnectStep({
const modelKnown = !isLocal || tags.includes(modelName);

const ready =
oauthProvider !== undefined ||
(isLocal
? baseURL.trim().length > 0 && modelName.trim().length > 0 && modelKnown
: apiKey.trim().length > 0);
option !== undefined &&
(oauthProvider !== undefined ||
(isLocal
? baseURL.trim().length > 0 && modelName.trim().length > 0 && modelKnown
: apiKey.trim().length > 0));

function fail(cause: unknown, operation: string) {
const refId = reportError(cause, { operation, tenantId });
Expand All @@ -215,7 +219,10 @@ export function ProviderConnectStep({
if (loginId !== null) {
// Abandoning a login must free the fixed loopback port it holds.
void cancelProviderLogin(tenantId, loginId).catch((cause: unknown) => {
reportError(cause, { operation: "onboarding.cancel-provider-login", tenantId });
reportError(cause, {
operation: "onboarding.cancel-provider-login",
tenantId,
});
});
setLoginId(null);
}
Expand Down Expand Up @@ -334,7 +341,7 @@ export function ProviderConnectStep({
<RadioGroup
name="provider"
label="Inference provider"
value={selected}
value={selected ?? ""}
onValueChange={selectOption}
>
{PROVIDER_OPTIONS.map((candidate) => (
Expand All @@ -346,7 +353,7 @@ export function ProviderConnectStep({
/>
))}
</RadioGroup>
{oauthProvider !== undefined ? (
{option === undefined ? null : oauthProvider !== undefined ? (
<p>
{waiting
? "Finish signing in on the tab that opened, then come back here."
Expand Down
Loading