Consolidate generateRefId into @corbits/error-sink

packages/error-sink/src/index.ts

@@ -86,3 +86,4 @@ export function reportError(
 }
 
 export type { ErrorContext } from "./context";
+export { generateRefId } from "./ref-id";

packages/error-sink/src/ref-id.test.ts

@@ -0,0 +1,14 @@
+import { describe, expect, test } from "bun:test";
+import { generateRefId } from "./ref-id";
+
+describe("generateRefId", () => {
+  test("produces a non-empty string", () => {
+    const refId = generateRefId();
+    expect(typeof refId).toBe("string");
+    expect(refId.length).toBeGreaterThan(0);
+  });
+
+  test("is not constant across calls", () => {
+    expect(generateRefId()).not.toBe(generateRefId());
+  });
+});

packages/error-sink/src/ref-id.ts

@@ -1,8 +1,9 @@
-// Mints the same short, quotable, grep-able shape `@workbench/hub-client`'s
-// `generateRefId` does, without depending on that package: hub-client
-// pulls in the full workflow-catalog and inference stack, which this
-// package's browser callers (and its own server-side ones) have no
-// reason to carry just to mint an id.
+// The sole implementation of the short, quotable, grep-able refId shape
+// (CL-7253). `@workbench/hub-client` re-exports this rather than keeping
+// its own copy; this package stays free of `@workbench/hub-client`'s
+// workflow-catalog and inference stack, which this package's browser
+// callers (and its own server-side ones) have no reason to carry just to
+// mint an id.
 export function generateRefId(): string {
   const random = Math.random().toString(36).slice(2, 8);
   return `${Date.now().toString(36)}-${random}`;

packages/hub-client/package.json

@@ -18,6 +18,7 @@
   "dependencies": {
     "@corbits/assistant-workflow": "workspace:*",
     "@corbits/echo-workflow": "workspace:*",
+    "@corbits/error-sink": "workspace:*",
     "@corbits/heartbeat-workflow": "workspace:*",
     "@corbits/inference-catalog": "workspace:*",
     "@corbits/last-30-days-research-workflow": "workspace:*",

packages/hub-client/src/error-envelope.test.ts

@@ -1,9 +1,5 @@
 import { describe, expect, test } from "bun:test";
-import {
-  generateRefId,
-  makeErrorEnvelope,
-  parseErrorEnvelope,
-} from "./error-envelope";
+import { makeErrorEnvelope, parseErrorEnvelope } from "./error-envelope";
 
 describe("error envelope", () => {
   test("makeErrorEnvelope carries code, userMessage, and a generated refId", () => {
@@ -19,10 +15,6 @@ describe("error envelope", () => {
     expect(envelope.error.refId.length).toBeGreaterThan(0);
   });
 
-  test("refIds are not constant across calls", () => {
-    expect(generateRefId()).not.toBe(generateRefId());
-  });
-
   test("parseErrorEnvelope accepts a well-formed envelope", () => {
     const body = {
       error: { code: "x", userMessage: "y", refId: "z" },

packages/hub-client/src/error-envelope.ts

@@ -6,8 +6,11 @@
 // hub's own logger, keyed by the same `refId`, so an operator can find
 // it without the client ever having seen it. See CL-6360.
 
+import { generateRefId } from "@corbits/error-sink";
 import { type } from "arktype";
 
+export { generateRefId };
+
 export const ErrorEnvelopeShape = type({
   error: {
     code: "string",
@@ -18,14 +21,6 @@ export const ErrorEnvelopeShape = type({
 
 export type ErrorEnvelope = typeof ErrorEnvelopeShape.infer;
 
-/** Short enough to read aloud, unique enough to grep a log for. Never a
- * secret and never derived from anything sensitive — it is a lookup key,
- * not a token. */
-export function generateRefId(): string {
-  const random = Math.random().toString(36).slice(2, 8);
-  return `${Date.now().toString(36)}-${random}`;
-}
-
 export function makeErrorEnvelope(args: {
   code: string;
   userMessage: string;